content/shell/shell_content_renderer_client.cc - Issue 8142032: Add error description to the DidFailProvisionalLoad callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/shell_content_renderer_client.cc

Issue 8142032: Add error description to the DidFailProvisionalLoad callback. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: update commit message with BUG and TEST fields Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/shell_content_renderer_client.cc

diff --git a/content/shell/shell_content_renderer_client.cc b/content/shell/shell_content_renderer_client.cc

index 0c5f499fbad8d2b7f7b2dd6a0af5c399141831b4..ab6ad0d8961e3fda8aae2eb476e48145b3fb91a2 100644

--- a/content/shell/shell_content_renderer_client.cc

+++ b/content/shell/shell_content_renderer_client.cc

@@ -41,10 +41,11 @@ bool ShellContentRendererClient::HasErrorPage(int http_status_code,

return false;

}

-std::string ShellContentRendererClient::GetNavigationErrorHtml(

+void ShellContentRendererClient::GetNavigationErrorStrings(

const WebKit::WebURLRequest& failed_request,

- const WebKit::WebURLError& error) {

- return std::string();

+ const WebKit::WebURLError& error,

+ std::string* error_html,

+ string16* error_description) {

}

bool ShellContentRendererClient::RunIdleHandlerWhenWidgetsHidden() {