Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2086)

Unified Diff: content/renderer/mock_content_renderer_client.cc

Issue 8142032: Add error description to the DidFailProvisionalLoad callback. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: incorporated feedback (style only, no functional changes) Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/mock_content_renderer_client.cc
diff --git a/content/renderer/mock_content_renderer_client.cc b/content/renderer/mock_content_renderer_client.cc
index b8a8e6de758b0c717e1ae2d1d758f643906794f1..22d28447fcc78beebdb6911df48ff17ae4358979 100644
--- a/content/renderer/mock_content_renderer_client.cc
+++ b/content/renderer/mock_content_renderer_client.cc
@@ -42,10 +42,15 @@ void MockContentRendererClient::ShowErrorPage(RenderView* render_view,
int http_status_code) {
}
-std::string MockContentRendererClient::GetNavigationErrorHtml(
+void MockContentRendererClient::GetNavigationErrorStrings(
const WebKit::WebURLRequest& failed_request,
- const WebKit::WebURLError& error) {
- return std::string();
+ const WebKit::WebURLError& error,
+ std::string* error_html,
+ string16* error_description) {
+ if (error_html != NULL)
jam 2011/10/07 16:03:28 nit: we prefer to have empty functions in the mock
mkosiba (inactive) 2011/10/07 17:54:32 Done.
+ *error_html = std::string();
+ if (error_description != NULL)
+ *error_description = string16();
}
bool MockContentRendererClient::RunIdleHandlerWhenWidgetsHidden() {

Powered by Google App Engine
This is Rietveld 408576698