chrome/browser/extensions/extension_webnavigation_api.h - Issue 8142032: Add error description to the DidFailProvisionalLoad callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webnavigation_api.h

Issue 8142032: Add error description to the DidFailProvisionalLoad callback. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: incorporated feedback (style only, no functional changes) Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_webnavigation_api.h

diff --git a/chrome/browser/extensions/extension_webnavigation_api.h b/chrome/browser/extensions/extension_webnavigation_api.h

index 92d098569014de2c793d5b18834908eeee801057..cdaea53d9da02109ddc555ff99c78787949d9ec0 100644

--- a/chrome/browser/extensions/extension_webnavigation_api.h

+++ b/chrome/browser/extensions/extension_webnavigation_api.h

@@ -142,10 +142,12 @@ class ExtensionWebNavigationTabObserver : public TabContentsObserver {

bool is_main_frame,

const GURL& url,

PageTransition::Type transition_type) OVERRIDE;

- virtual void DidFailProvisionalLoad(int64 frame_id,

- bool is_main_frame,

- const GURL& validated_url,

- int error_code) OVERRIDE;

+ virtual void DidFailProvisionalLoad(

+ int64 frame_id,

+ bool is_main_frame,

+ const GURL& validated_url,

+ int error_code,

+ const string16& error_description) OVERRIDE;

virtual void DocumentLoadedInFrame(int64 frame_id) OVERRIDE;

virtual void DidFinishLoad(int64 frame_id) OVERRIDE;

virtual void TabContentsDestroyed(TabContents* tab) OVERRIDE;