Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: content/browser/tab_contents/tab_contents.h

Issue 8142032: Add error description to the DidFailProvisionalLoad callback. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: removed unnecessary change Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents.h
diff --git a/content/browser/tab_contents/tab_contents.h b/content/browser/tab_contents/tab_contents.h
index 7ecd21cfe35ee55349ac33761b5b15d3c29177c6..98b993fa60d27b5c57df645a2b1045db131abadd 100644
--- a/content/browser/tab_contents/tab_contents.h
+++ b/content/browser/tab_contents/tab_contents.h
@@ -58,6 +58,7 @@ struct ViewHostMsg_FrameNavigate_Params;
struct WebPreferences;
class WebUI;
struct ViewHostMsg_RunFileChooser_Params;
+struct ViewHostMsg_DidFailProvisionalLoadWithError_Params;
mmenke 2011/10/07 14:19:44 nit: Alphabetize.
mkosiba (inactive) 2011/10/07 15:46:11 Done.
// Describes what goes in the main content area of a tab. TabContents is
// the only type of TabContents, and these should be merged together.
@@ -522,11 +523,8 @@ class CONTENT_EXPORT TabContents : public PageNavigator,
bool has_opener_set,
const GURL& source_url,
const GURL& target_url);
- void OnDidFailProvisionalLoadWithError(int64 frame_id,
- bool main_frame,
- int error_code,
- const GURL& url,
- bool showing_repost_interstitial);
+ void OnDidFailProvisionalLoadWithError(
+ const ViewHostMsg_DidFailProvisionalLoadWithError_Params& ipc_params);
mmenke 2011/10/07 14:19:44 nit: ipc_params -> params
mkosiba (inactive) 2011/10/07 15:46:11 Done.
void OnDidLoadResourceFromMemoryCache(const GURL& url,
const std::string& security_info,
const std::string& http_request,

Powered by Google App Engine
This is Rietveld 408576698