Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: content/public/renderer/content_renderer_client.h

Issue 8142032: Add error description to the DidFailProvisionalLoad callback. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/content_renderer_client.h
diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h
index 3ed428b355021854c81604172f4364e2a6a33293..adb967207d7524912666210773e101a56997243b 100644
--- a/content/public/renderer/content_renderer_client.h
+++ b/content/public/renderer/content_renderer_client.h
@@ -72,6 +72,11 @@ class ContentRendererClient {
const WebKit::WebURLRequest& failed_request,
const WebKit::WebURLError& error) = 0;
+ // Returns the error message that is shown when a navigation error occurs.
+ virtual string16 GetNavigationErrorDescription(
jam 2011/10/05 17:12:06 why add another function instead of an extra param
mkosiba (inactive) 2011/10/05 17:53:18 You mean have one function return both/either the
jam 2011/10/05 19:33:57 sure
+ const WebKit::WebURLRequest& failed_request,
+ const WebKit::WebURLError& error) = 0;
+
// Returns true if the renderer process should schedule the idle handler when
// all widgets are hidden.
virtual bool RunIdleHandlerWhenWidgetsHidden() = 0;

Powered by Google App Engine
This is Rietveld 408576698