Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 8142030: Move mutation in run() at the end. (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Move mutation in run() at the end. Also, add more locking to properties. Now most mutations are contained. Will now figure out a way to remove the ParseDepsFile() from an unrelated thread. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104778

Patch Set 1 #

Patch Set 2 : cleaner #

Patch Set 3 : . #

Patch Set 4 : rebase against 8135019 #

Patch Set 5 : Fix regression introduced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -65 lines) Patch
M gclient.py View 1 2 3 4 6 chunks +92 lines, -65 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-10-05 13:50:26 UTC) #1
Dirk Pranke
lgtm
9 years, 2 months ago (2011-10-05 21:06:07 UTC) #2
M-A Ruel
I had to modify to make it work as it was reading self.parsed_url. Since I ...
9 years, 2 months ago (2011-10-07 16:15:12 UTC) #3
Dirk Pranke
lgtm (again).
9 years, 2 months ago (2011-10-07 20:43:47 UTC) #4
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8142030/13001
9 years, 2 months ago (2011-10-10 20:43:44 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-10 20:49:48 UTC) #6
Change committed as 104778

Powered by Google App Engine
This is Rietveld 408576698