Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 8139037: Don't count duplicate assignments to the same property as distinct ones. (Closed)

Created:
9 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Don't count duplicate assignments to the same property as distinct ones. In the ThisNamedPropertyAssignmentFinder, duplicate assignments to the same property were counted as distinct assignments. As a simple fix, subsequent ones overwrite the previously recorded assignment. This will reorder the assignments, but it is safe since they are restricted to have only constants and parameters on the right-hand side (and there are no assignments to the parameters). R=vegorov@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -36 lines) Patch
M src/parser.cc View 5 chunks +53 lines, -36 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
I have a reduced test for this, but it requires concatenating two different test files. ...
9 years, 2 months ago (2011-10-05 18:01:34 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 2 months ago (2011-10-05 18:27:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698