Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 8139029: Make policy errors available to display in about:policy. (Closed)

Created:
9 years, 2 months ago by Joao da Silva
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Make policy errors available to display in about:policy. This is the continuation of http://codereview.chromium.org/7972013/ BUG=99178 TEST=Everything works as before, no visible changes yet Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107115

Patch Set 1 #

Patch Set 2 : Fix awesome include #

Patch Set 3 : Rebased, fixed proxy handler, other fixes #

Patch Set 4 : Cleanups #

Patch Set 5 : Removed BookmarksPolicyHandler, rebased #

Patch Set 6 : Fix bad commit #

Total comments: 26

Patch Set 7 : Reviewed #

Patch Set 8 : Rebased, reviewed; using GetPolicyName, added IDS_POLICY_OVERRIDDEN #

Patch Set 9 : Rebased. Using policy::GetPolicyName. Delay PolicyErrorMap string localizations. #

Patch Set 10 : Fixed unused replacement string DCHECK from policy_error_map.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1721 lines, -976 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 7 8 9 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.h View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 2 3 4 5 6 7 8 5 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/policy/config_dir_policy_provider_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -10 lines 0 comments Download
A chrome/browser/policy/configuration_policy_handler.h View 1 2 3 4 5 6 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/policy/configuration_policy_handler.cc View 1 2 3 4 5 6 7 8 1 chunk +1328 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.h View 1 2 3 4 5 6 7 4 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 1 2 3 4 5 6 7 8 7 chunks +56 lines, -955 lines 0 comments Download
M chrome/browser/policy/device_management_backend_mock.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/policy/policy_error_map.h View 1 2 3 4 5 6 7 8 1 chunk +77 lines, -0 lines 0 comments Download
A chrome/browser/policy/policy_error_map.cc View 1 2 3 4 5 6 7 8 9 1 chunk +117 lines, -0 lines 0 comments Download
M chrome/browser/policy/policy_map.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/policy_map.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_path_parser.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/policy_status_info.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -0 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Joao da Silva
Here we go! :-) Please review. A list of changes since Simo's last iteration: - ...
9 years, 2 months ago (2011-10-10 17:18:35 UTC) #1
Mattias Nissler (ping if slow)
http://codereview.chromium.org/8139029/diff/23001/chrome/browser/policy/configuration_policy_handler.cc File chrome/browser/policy/configuration_policy_handler.cc (right): http://codereview.chromium.org/8139029/diff/23001/chrome/browser/policy/configuration_policy_handler.cc#newcode37 chrome/browser/policy/configuration_policy_handler.cc:37: remove some extra white space? http://codereview.chromium.org/8139029/diff/23001/chrome/browser/policy/configuration_policy_handler.cc#newcode66 chrome/browser/policy/configuration_policy_handler.cc:66: nit: remove ...
9 years, 2 months ago (2011-10-11 11:10:56 UTC) #2
Joao da Silva
Thanks for the comments. Please have another look. The changes to pref_value_map have been reverted, ...
9 years, 2 months ago (2011-10-11 15:09:23 UTC) #3
Mattias Nissler (ping if slow)
Except for the unresolved issue regarding GetPolicyName(), LGTM. We might as well consolidate GetPolicyName() later. ...
9 years, 2 months ago (2011-10-12 17:10:00 UTC) #4
Joao da Silva
Please have another look. Usage of GetPolicyName() has been fixed, see inline. The remaining issue ...
9 years, 2 months ago (2011-10-21 14:22:20 UTC) #5
Mattias Nissler (ping if slow)
LGTM
9 years, 2 months ago (2011-10-24 09:24:53 UTC) #6
Joao da Silva
ConfigurationPolicyPrefStoreProxyTest.ManualOptionsInvalid failed on all platforms, and it turns out that l10n_util::GetStringFUTF16 DCHECKS that all replacement ...
9 years, 2 months ago (2011-10-25 13:37:31 UTC) #7
Mattias Nissler (ping if slow)
lgtm
9 years, 2 months ago (2011-10-25 13:50:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/8139029/39001
9 years, 2 months ago (2011-10-25 13:52:04 UTC) #9
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 15:07:14 UTC) #10
Change committed as 107115

Powered by Google App Engine
This is Rietveld 408576698