Issue 8137027: net: disable 1/n-1 record splitting when False Start is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8137027: net: disable 1/n-1 record splitting when False Start is disabled. (Closed)

Created:
9 years, 2 months ago by agl

Modified:
9 years, 2 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

net: disable 1/n-1 record splitting when False Start is disabled. Brocade SSL terminators are intolerant to 1/n-1 record splitting as well. For the sake of getting M15 out the door, this patch uses the False Start blacklist in order to switch off 1/n-1 record splitting too. This is deeply unfortunate but will be reverted on trunk as soon as it can be merged to M15. BUG=98908 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104119

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -13 lines)			Patch
	M	net/third_party/nss/patches/cbcrandomiv.patch	View		5 chunks	+14 lines, -13 lines	0 comments	Download
	M	net/third_party/nss/ssl/ssl3con.c	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/8137027/diff/1/net/third_party/nss/ssl/ssl3con.c File net/third_party/nss/ssl/ssl3con.c (right): http://codereview.chromium.org/8137027/diff/1/net/third_party/nss/ssl/ssl3con.c#newcode2233 net/third_party/nss/ssl/ssl3con.c:2233: ss->opt.enableFalseStart == PR_TRUE && Nit: remove " == ...

9 years, 2 months ago (2011-10-05 15:47:21 UTC) #2

agl

9 years, 2 months ago (2011-10-05 16:27:39 UTC) #3

thanks.

http://codereview.chromium.org/8137027/diff/1/net/third_party/nss/ssl/ssl3con.c
File net/third_party/nss/ssl/ssl3con.c (right):

http://codereview.chromium.org/8137027/diff/1/net/third_party/nss/ssl/ssl3con...
net/third_party/nss/ssl/ssl3con.c:2233: ss->opt.enableFalseStart == PR_TRUE &&
On 2011/10/05 15:47:21, wtc wrote:
> 
> Nit: remove " == PR_TRUE".

Done and have updated the patch.

Expand Messages | Collapse Messages