Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: chrome/test/base/chrome_test_launcher.cc

Issue 8137012: Make an empty content browser test work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/chrome_test_launcher.cc
===================================================================
--- chrome/test/base/chrome_test_launcher.cc (revision 104112)
+++ chrome/test/base/chrome_test_launcher.cc (working copy)
@@ -41,37 +41,8 @@
}
virtual bool Run(int argc, char** argv, int* return_code) OVERRIDE {
- CommandLine* command_line = CommandLine::ForCurrentProcess();
-
- // TODO(pkasting): This "single_process vs. single-process" design is
- // terrible UI. Instead, there should be some sort of signal flag on the
- // command line, with all subsequent arguments passed through to the
- // underlying browser.
- if (command_line->HasSwitch(test_launcher::kSingleProcessTestsFlag) ||
- command_line->HasSwitch(
- test_launcher::kSingleProcessTestsAndChromeFlag) ||
- command_line->HasSwitch(test_launcher::kGTestListTestsFlag) ||
- command_line->HasSwitch(test_launcher::kGTestHelpFlag)) {
#if defined(OS_WIN)
- if (command_line->HasSwitch(test_launcher::kSingleProcessTestsFlag)) {
- // This is the browser process, so setup the sandbox broker.
- sandbox::BrokerServices* broker_services =
- sandbox::SandboxFactory::GetBrokerServices();
- if (broker_services) {
- sandbox::InitBrokerServices(broker_services);
- // Precreate the desktop and window station used by the renderers.
- sandbox::TargetPolicy* policy = broker_services->CreatePolicy();
- sandbox::ResultCode result = policy->CreateAlternateDesktop(true);
- CHECK(sandbox::SBOX_ERROR_FAILED_TO_SWITCH_BACK_WINSTATION != result);
- policy->Release();
- }
- }
-#endif
- *return_code = ChromeTestSuite(argc, argv).Run();
- return true;
- }
-
-#if defined(OS_WIN)
+ CommandLine* command_line = CommandLine::ForCurrentProcess();
if (command_line->HasSwitch(switches::kProcessType)) {
// This is a child process, call ChromeMain.
FilePath chrome_path(command_line->GetProgram().DirName());
@@ -91,9 +62,14 @@
return true;
}
#endif // defined(OS_WIN)
+
return false;
}
+ virtual int RunTestSuite(int argc, char** argv) OVERRIDE {
+ return ChromeTestSuite(argc, argv).Run();
+ }
+
virtual bool AdjustChildProcessCommandLine(
CommandLine* command_line) OVERRIDE {
CommandLine new_command_line(command_line->GetProgram());
« no previous file with comments | « no previous file | content/browser/browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698