Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: chrome/browser/printing/background_printing_manager.h

Issue 8136027: Print Preview: Make print preview tab modal. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase, no renderer changes Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/background_printing_manager.h
===================================================================
--- chrome/browser/printing/background_printing_manager.h (revision 108195)
+++ chrome/browser/printing/background_printing_manager.h (working copy)
@@ -35,13 +35,6 @@
// hides it from the user.
void OwnPrintPreviewTab(TabContentsWrapper* preview_tab);
- // Takes ownership of |initiator_tab| and deletes it when its preview tab is
- // destroyed by either being canceled, closed or finishing printing. This
- // removes the TabContentsWrapper from its TabStrip and hides it from the
- // user. Returns true if content has an associated print preview tab,
- // otherwise, returns false and does not take ownership of |initiator_tab|.
- bool OwnInitiatorTab(TabContentsWrapper* initiator_tab);
-
// Let others iterate over the list of background printing tabs.
TabContentsWrapperSet::const_iterator begin();
TabContentsWrapperSet::const_iterator end();
@@ -55,17 +48,11 @@
const content::NotificationDetails& details) OVERRIDE;
private:
- typedef std::map<TabContentsWrapper*, TabContentsWrapper*>
- TabContentsWrapperMap;
-
// Notifications handlers.
void OnRendererProcessClosed(RenderProcessHost* rph);
void OnPrintJobReleased(TabContentsWrapper* preview_tab);
void OnTabContentsDestroyed(TabContentsWrapper* preview_tab);
- // Removes |tab| from its tab strip.
- void RemoveFromTabStrip(TabContentsWrapper* tab);
-
// Add |tab| to the pending deletion set and schedule deletion.
void DeletePreviewTab(TabContentsWrapper* tab);
@@ -81,13 +68,6 @@
// are pending deletion.
TabContentsWrapperSet printing_tabs_pending_deletion_;
- // 1:1 mapping between an initiator tab managed by BackgroundPrintingManager
- // and its associated print preview tab. The print preview tab need not be in
- // |printing_tabs_|.
- // Key: print preview tab.
- // Value: initiator tab.
- TabContentsWrapperMap map_;
-
content::NotificationRegistrar registrar_;
DISALLOW_COPY_AND_ASSIGN(BackgroundPrintingManager);

Powered by Google App Engine
This is Rietveld 408576698