Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: chrome/browser/ui/browser.cc

Issue 8136027: Print Preview: Make print preview tab modal. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix print to pdf for window.print Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
===================================================================
--- chrome/browser/ui/browser.cc (revision 105575)
+++ chrome/browser/ui/browser.cc (working copy)
@@ -69,7 +69,6 @@
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/prerender/prerender_tab_helper.h"
-#include "chrome/browser/printing/background_printing_manager.h"
#include "chrome/browser/printing/cloud_print/cloud_print_setup_flow.h"
#include "chrome/browser/printing/print_preview_tab_controller.h"
#include "chrome/browser/printing/print_view_manager.h"
@@ -3457,19 +3456,6 @@
return;
}
- // Various sites have a pattern which open a new window with output formatted
- // for printing, then include a print button, which does window.print();
- // window.close(); An example is printing Virgin America boarding
- // pass. Instead of closing, when a print tab is associated with this tab,
- // tell the BackgroundPrintingManager to own it, which causes it to be
- // hidden and eventually closed when the print window is closed.
- TabContentsWrapper* source_wrapper =
- TabContentsWrapper::GetCurrentWrapperForContents(source);
- if (g_browser_process->background_printing_manager()->
- OwnInitiatorTab(source_wrapper)) {
- return;
- }
-
int index = tab_handler_->GetTabStripModel()->GetWrapperIndex(source);
if (index == TabStripModel::kNoTab) {
NOTREACHED() << "CloseContents called for tab not in our strip";
@@ -3740,6 +3726,21 @@
}
void Browser::RendererUnresponsive(TabContents* source) {
+ // Ignore hangs if print preview is open.
+ TabContentsWrapper* source_wrapper =
+ TabContentsWrapper::GetCurrentWrapperForContents(source);
+ if (source_wrapper) {
+ printing::PrintPreviewTabController* controller =
+ printing::PrintPreviewTabController::GetInstance();
+ if (controller) {
+ TabContentsWrapper* preview_tab =
+ controller->GetPrintPreviewForTab(source_wrapper);
+ if (preview_tab && preview_tab != source_wrapper) {
+ return;
+ }
+ }
+ }
+
browser::ShowHungRendererDialog(source);
}
@@ -4530,9 +4531,7 @@
// where advanced printing is always enabled.
printing::PrintPreviewTabController* controller =
printing::PrintPreviewTabController::GetInstance();
- if (controller &&
- wrapper &&
- wrapper == controller->GetPrintPreviewForTab(wrapper)) {
+ if (controller && controller->GetPrintPreviewForTab(wrapper)) {
advanced_print_enabled = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698