Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: chrome/browser/printing/print_view_manager.h

Issue 8136027: Print Preview: Make print preview tab modal. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_view_manager.h
===================================================================
--- chrome/browser/printing/print_view_manager.h (revision 105532)
+++ chrome/browser/printing/print_view_manager.h (working copy)
@@ -33,10 +33,6 @@
explicit PrintViewManager(TabContentsWrapper* tab);
virtual ~PrintViewManager();
- // Override the title for this PrintViewManager's PrintJobs using the title
- // in |tab_contents|.
- void OverrideTitle(TabContents* tab_contents);
-
// Prints the current document immediately. Since the rendering is
// asynchronous, the actual printing will not be completed on the return of
// this function. Returns false if printing is impossible at the moment.
@@ -60,14 +56,14 @@
// Handles cancelled preview printing request.
void PreviewPrintingRequestCancelled();
+ // Let the renderer know print preview has finished.
+ void PrintPreviewDone();
+
// Sets |observer| as the current PrintViewManagerObserver. Pass in NULL to
// remove the current observer. |observer| may always be NULL, but |observer_|
// must be NULL if |observer| is non-NULL.
void set_observer(PrintViewManagerObserver* observer);
- // Reset |is_title_overridden_| to false.
- void ResetTitleOverride();
-
// PrintedPagesSource implementation.
virtual string16 RenderSourceName() OVERRIDE;
@@ -168,10 +164,6 @@
bool expecting_first_page_;
#endif
- // Title override.
- bool is_title_overridden_;
- string16 overridden_title_;
-
// Weak pointer to an observer that is notified when the print dialog is
// shown.
PrintViewManagerObserver* observer_;

Powered by Google App Engine
This is Rietveld 408576698