Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4841)

Unified Diff: chrome/browser/printing/print_preview_message_handler.cc

Issue 8136027: Print Preview: Make print preview tab modal. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_preview_message_handler.cc
===================================================================
--- chrome/browser/printing/print_preview_message_handler.cc (revision 105532)
+++ chrome/browser/printing/print_preview_message_handler.cc (working copy)
@@ -171,8 +171,6 @@
return;
}
- print_preview_tab->print_view_manager()->OverrideTitle(tab_contents());
-
// TODO(joth): This seems like a good match for using RefCountedStaticMemory
// to avoid the memory copy, but the SetPrintPreviewData call chain below
// needs updating to accept the RefCountedMemory* base class.
@@ -243,10 +241,38 @@
}
void PrintPreviewMessageHandler::DidStartLoading() {
- if (tab_contents()->delegate() &&
- PrintPreviewTabController::IsPrintPreviewTab(tab_contents_wrapper())) {
- tab_contents()->SetContentRestrictions(CONTENT_RESTRICTION_PRINT);
+ TabContentsWrapper* tab_wrapper = tab_contents_wrapper();
+ TabContents* tab = tab_contents();
+ if (tab->delegate() &&
+ PrintPreviewTabController::IsPrintPreviewTab(tab_wrapper)) {
+ tab->SetContentRestrictions(CONTENT_RESTRICTION_PRINT);
+
+ // Need to get the initiator tab to enabled advanced printing.
+ PrintPreviewTabController* tab_controller =
+ PrintPreviewTabController::GetInstance();
+ if (tab_controller) {
+ TabContentsWrapper* initiator_tab_wrapper =
+ tab_controller->GetInitiatorTab(tab_wrapper);
+ if (initiator_tab_wrapper) {
+ TabContents* initiator_tab = initiator_tab_wrapper->tab_contents();
+ initiator_tab->SetContentRestrictions(
+ initiator_tab->content_restrictions());
+ }
+ }
}
}
+void PrintPreviewMessageHandler::NavigateToPendingEntry(
+ const GURL& url,
+ NavigationController::ReloadType reload_type) {
+ TabContentsWrapper* tab = tab_contents_wrapper();
+ TabContentsWrapper* preview_tab = GetPrintPreviewTab();
+ if (tab == preview_tab) {
+ NOTREACHED();
+ return;
+ }
+ if (preview_tab)
+ tab->print_view_manager()->PrintPreviewDone();
+}
+
} // namespace printing

Powered by Google App Engine
This is Rietveld 408576698