Print Preview: Make print preview tab modal.

chrome/browser/ui/webui/print_preview_ui.h

Index: chrome/browser/ui/webui/print_preview_ui.h
===================================================================
--- chrome/browser/ui/webui/print_preview_ui.h	(revision 105366)
+++ chrome/browser/ui/webui/print_preview_ui.h	(working copy)
@@ -12,7 +12,7 @@
 #include "base/memory/ref_counted_memory.h"
 #include "base/time.h"
 #include "chrome/browser/printing/print_preview_data_service.h"
-#include "chrome/browser/ui/webui/chrome_web_ui.h"
+#include "chrome/browser/ui/webui/constrained_html_ui.h"
 
 class PrintPreviewDataService;
 class PrintPreviewHandler;
@@ -22,7 +22,7 @@
 struct PageSizeMargins;
 }
 
-class PrintPreviewUI : public ChromeWebUI {
+class PrintPreviewUI : public ConstrainedHtmlUI {
  public:
   explicit PrintPreviewUI(TabContents* contents);
   virtual ~PrintPreviewUI();
@@ -96,13 +96,13 @@
   // Notifies the Web UI that the print preview failed to render.
   void OnPrintPreviewFailed();
 
+  // Notified the Web UI that this print preview tab has crashed.
+  void OnPrintPreviewTabCrashed();

[vandebo (ex-Chrome), 2011/10/14 07:14:05]

You removed the other tab crashed code, do you still want/need this?

[Lei Zhang, 2011/10/14 20:31:27]

Yes, we can't leave the user with a sad tab in a constrained dialog with no way
to close it.

+
   // Notifies the Web UI that initiator tab is closed, so we can disable all the
   // controls that need the initiator tab for generating the preview data.
   void OnInitiatorTabClosed();
 
-  // Notifies the Web UI that the initiator tab has crashed.
-  void OnInitiatorTabCrashed();
-
   // Notifies the Web UI renderer that file selection has been cancelled.
   void OnFileSelectionCancelled();
 
@@ -113,6 +113,12 @@
   // Notifies the Web UI to cancel the pending preview request.
   void OnCancelPendingPreviewRequest();
 
+  // Hide the print preview tab.
+  void HidePreviewTab();
+
+  // Close the print preview tab.
+  void ClosePrintPreviewTab();
+
  private:
   FRIEND_TEST_ALL_PREFIXES(PrintPreviewTabControllerUnitTest,
                            TitleAfterReload);