Print Preview: Make print preview tab modal.

chrome/browser/ui/browser.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // OS_WIN
@@ skipping 51 matching lines @@
 #include "chrome/browser/instant/instant_unload_handler.h"
 #include "chrome/browser/intents/register_intent_handler_infobar_delegate.h"
 #include "chrome/browser/intents/web_intents_registry_factory.h"
 #include "chrome/browser/net/browser_url_util.h"
 #include "chrome/browser/net/url_fixer_upper.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/prerender/prerender_tab_helper.h"
-#include "chrome/browser/printing/background_printing_manager.h"
 #include "chrome/browser/printing/cloud_print/cloud_print_setup_flow.h"
 #include "chrome/browser/printing/print_preview_tab_controller.h"
 #include "chrome/browser/printing/print_view_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sessions/restore_tab_helper.h"
 #include "chrome/browser/sessions/session_service.h"
 #include "chrome/browser/sessions/session_service_factory.h"
 #include "chrome/browser/sessions/session_types.h"
 #include "chrome/browser/sessions/tab_restore_service.h"
 #include "chrome/browser/sessions/tab_restore_service_factory.h"
@@ skipping 3360 matching lines @@
 void Browser::CloseContents(TabContents* source) {
   if (is_attempting_to_close_browser_) {
     // If we're trying to close the browser, just clear the state related to
     // waiting for unload to fire. Don't actually try to close the tab as it
     // will go down the slow shutdown path instead of the fast path of killing
     // all the renderer processes.
     ClearUnloadState(source, true);
     return;
   }
 
-  // Various sites have a pattern which open a new window with output formatted
-  // for printing, then include a print button, which does window.print();
-  // window.close(); An example is printing Virgin America boarding
-  // pass. Instead of closing, when a print tab is associated with this tab,
-  // tell the BackgroundPrintingManager to own it, which causes it to be
-  // hidden and eventually closed when the print window is closed.
-  TabContentsWrapper* source_wrapper =
-      TabContentsWrapper::GetCurrentWrapperForContents(source);
-  if (g_browser_process->background_printing_manager()->
-          OwnInitiatorTab(source_wrapper)) {
-    return;
-  }
-
   int index = tab_handler_->GetTabStripModel()->GetWrapperIndex(source);
   if (index == TabStripModel::kNoTab) {
     NOTREACHED() << "CloseContents called for tab not in our strip";
     return;
   }
   tab_handler_->GetTabStripModel()->CloseTabContentsAt(
       index,
       TabStripModel::CLOSE_CREATE_HISTORICAL_TAB);
 }
 
@@ skipping 250 matching lines @@
     NavigationType::Type navigation_type) {
   // Don't update history if running as app.
   return !IsApplication();
 }
 
 void Browser::ContentRestrictionsChanged(TabContents* source) {
   UpdateCommandsForContentRestrictionState();
 }
 
 void Browser::RendererUnresponsive(TabContents* source) {
+  // Ignore hangs if print preview is open.
+  TabContentsWrapper* source_wrapper =
+      TabContentsWrapper::GetCurrentWrapperForContents(source);
+  if (source_wrapper) {
+    printing::PrintPreviewTabController* controller =
+        printing::PrintPreviewTabController::GetInstance();
+    if (controller) {
+      TabContentsWrapper* preview_tab =
+          controller->GetPrintPreviewForTab(source_wrapper);
+      if (preview_tab && preview_tab != source_wrapper) {
+        return;
+      }
+    }
+  }
+
   browser::ShowHungRendererDialog(source);
 }
 
 void Browser::RendererResponsive(TabContents* source) {
   browser::HideHungRendererDialog(source);
 }
 
 void Browser::WorkerCrashed(TabContents* source) {
   TabContentsWrapper* wrapper =
       TabContentsWrapper::GetCurrentWrapperForContents(source);
@@ skipping 770 matching lines @@
     if (has_constrained_window ||
         content_restrictions & CONTENT_RESTRICTION_PRINT) {
       print_enabled = false;
       advanced_print_enabled = false;
     }
 
     // The exception is print preview,
     // where advanced printing is always enabled.
     printing::PrintPreviewTabController* controller =
         printing::PrintPreviewTabController::GetInstance();
-    if (controller &&
-        wrapper &&
-        wrapper == controller->GetPrintPreviewForTab(wrapper)) {
+    if (controller && controller->GetPrintPreviewForTab(wrapper)) {

[kmadhusu, 2011/10/14 00:21:09]

nit: {} not required

[Lei Zhang, 2011/10/14 20:31:27]

I like it for readability for nested if blocks.

       advanced_print_enabled = true;
     }
   }
   command_updater_.UpdateCommandEnabled(IDC_PRINT, print_enabled);
   command_updater_.UpdateCommandEnabled(IDC_ADVANCED_PRINT,
                                         advanced_print_enabled);
 }
 
 void Browser::UpdateReloadStopState(bool is_loading, bool force) {
   window_->UpdateReloadStopState(is_loading, force);
@@ skipping 767 matching lines @@
     window_->GetLocationBar()->ShowFirstRunBubble(bubble_type);
   } else if (is_type_tabbed()) {
     GlobalErrorService* service =
         GlobalErrorServiceFactory::GetForProfile(profile());
     GlobalError* error = service->GetFirstGlobalErrorWithBubbleView();
     if (error) {
       error->ShowBubbleView(this);
     }
   }
 }