Print Preview: Make print preview tab modal.

chrome/browser/ui/webui/print_preview_ui_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted_memory.h"
 #include "chrome/browser/printing/print_preview_tab_controller.h"
 #include "chrome/browser/ui/browser_list.h"
@@ skipping 27 matching lines @@
   ASSERT_TRUE(initiator_tab);
 
   scoped_refptr<printing::PrintPreviewTabController>
       controller(new printing::PrintPreviewTabController());
   ASSERT_TRUE(controller);
 
   TabContentsWrapper* preview_tab =
       controller->GetOrCreatePreviewTab(initiator_tab);
 
   EXPECT_NE(initiator_tab, preview_tab);
-  EXPECT_EQ(2, browser()->tab_count());
+  EXPECT_EQ(1, browser()->tab_count());

[kmadhusu, 2011/10/13 18:52:18]

Can you add a check to confirm that the count of constrained windows is 1?

[Lei Zhang, 2011/10/13 21:12:12]

Done. I can add it to other tests later.

 
   PrintPreviewUI* preview_ui =
       reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());
   ASSERT_TRUE(preview_ui != NULL);
 
   scoped_refptr<RefCountedBytes> data;
   preview_ui->GetPrintPreviewDataForIndex(
       printing::COMPLETE_PREVIEW_DOCUMENT_INDEX,
       &data);
   EXPECT_EQ(NULL, data.get());
@@ skipping 39 matching lines @@
   ASSERT_TRUE(initiator_tab);
 
   scoped_refptr<printing::PrintPreviewTabController>
       controller(new printing::PrintPreviewTabController());
   ASSERT_TRUE(controller);
 
   TabContentsWrapper* preview_tab =
       controller->GetOrCreatePreviewTab(initiator_tab);
 
   EXPECT_NE(initiator_tab, preview_tab);
-  EXPECT_EQ(2, browser()->tab_count());
+  EXPECT_EQ(1, browser()->tab_count());
 
   PrintPreviewUI* preview_ui =
       reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());
   ASSERT_TRUE(preview_ui != NULL);
 
   scoped_refptr<RefCountedBytes> data;
   preview_ui->GetPrintPreviewDataForIndex(printing::FIRST_PAGE_INDEX, &data);
   EXPECT_EQ(NULL, data.get());
 
   std::vector<unsigned char> preview_data(blob1, blob1 + sizeof(blob1));
@@ skipping 46 matching lines @@
   ASSERT_TRUE(initiator_tab);
 
   scoped_refptr<printing::PrintPreviewTabController>
       controller(new printing::PrintPreviewTabController());
   ASSERT_TRUE(controller);
 
   TabContentsWrapper* preview_tab =
       controller->GetOrCreatePreviewTab(initiator_tab);
 
   EXPECT_NE(initiator_tab, preview_tab);
-  EXPECT_EQ(2, browser()->tab_count());
+  EXPECT_EQ(1, browser()->tab_count());
 
   PrintPreviewUI* preview_ui =
       reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());
   ASSERT_TRUE(preview_ui != NULL);
 
   // Test with invalid |preview_ui_addr|.
   bool cancel = false;
   preview_ui->GetCurrentPrintPreviewStatus("invalid", 0, &cancel);
   EXPECT_TRUE(cancel);
 
@@ skipping 18 matching lines @@
   cancel = false;
   preview_ui->GetCurrentPrintPreviewStatus(preview_ui_addr, kFirstRequestId,
                                            &cancel);
   EXPECT_TRUE(cancel);
 
   cancel = true;
   preview_ui->GetCurrentPrintPreviewStatus(preview_ui_addr, kSecondRequestId,
                                            &cancel);
   EXPECT_FALSE(cancel);
 }