Issue 8136005: Makes visbility inherited. That is, in order for a window to be

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8136005: Makes visbility inherited. That is, in order for a window to be (Closed)

Created:
9 years, 2 months ago by sky

Modified:
9 years, 2 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dhollowa, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Makes visbility inherited. That is, in order for a window to be visible all of its ancestor must be visible too. BUG=none TEST=covered by unit tests. R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104097

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Window now gets visibility from Layer. #

Total comments: 1

Patch Set 4 : Merge to trunk #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -28 lines)			Patch
M	ui/aura/desktop.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/aura/window.h	View	1 2 3	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ui/aura/window.cc	View	1 2 3	6 chunks	+15 lines, -9 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1 2 3	1 chunk	+37 lines, -0 lines	0 comments	Download
M	ui/aura_shell/examples/window_type_launcher.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/gfx/compositor/layer.h	View	1 2	2 chunks	+7 lines, -2 lines	0 comments	Download
M	ui/gfx/compositor/layer.cc	View	1 2 3	3 chunks	+19 lines, -4 lines	0 comments	Download
M	ui/gfx/compositor/layer_unittest.cc	View	1 2 3	2 chunks	+46 lines, -6 lines	0 comments	Download
M	views/view_unittest.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	views/widget/native_widget_aura.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

Updated so that Window::IsVisible now comes from Layer. -Scott

9 years, 2 months ago (2011-10-04 23:07:33 UTC) #2

Ben Goodger (Google)

9 years, 2 months ago (2011-10-05 01:44:09 UTC) #3

LGTM

http://codereview.chromium.org/8136005/diff/3006/ui/aura/window.cc
File ui/aura/window.cc (right):

http://codereview.chromium.org/8136005/diff/3006/ui/aura/window.cc#newcode63
ui/aura/window.cc:63: layer_->SetVisible(false);
therefore

also, I think we should make control-type windows initially visible. but we
don't have window types yet... so can you just drop a TODO here?

Expand Messages | Collapse Messages