Chromium Code Reviews| Index: test/cctest/test-weakmaps.cc |
| diff --git a/test/cctest/test-weakmaps.cc b/test/cctest/test-weakmaps.cc |
| index db4db25435f7b6aa18f562c8f5a6ad6848548274..81559c6240f4c6ad441d82134b37d987eea73f2b 100644 |
| --- a/test/cctest/test-weakmaps.cc |
| +++ b/test/cctest/test-weakmaps.cc |
| @@ -50,7 +50,7 @@ static void PutIntoWeakMap(Handle<JSWeakMap> weakmap, |
| Handle<JSObject> key, |
| int value) { |
| Handle<ObjectHashTable> table = PutIntoObjectHashTable( |
| - Handle<ObjectHashTable>(weakmap->table()), |
| + Handle<ObjectHashTable>(ObjectHashTable::cast(weakmap->table())), |
| Handle<JSObject>(JSObject::cast(*key)), |
| Handle<Smi>(Smi::FromInt(value))); |
| weakmap->set_table(*table); |
| @@ -85,13 +85,14 @@ TEST(Weakness) { |
| v8::HandleScope scope; |
| PutIntoWeakMap(weakmap, Handle<JSObject>(JSObject::cast(*key)), 23); |
| } |
| - CHECK_EQ(1, weakmap->table()->NumberOfElements()); |
| + CHECK_EQ(1, ObjectHashTable::cast(weakmap->table())->NumberOfElements()); |
| // Force a full GC. |
| HEAP->CollectAllGarbage(false); |
| CHECK_EQ(0, NumberOfWeakCalls); |
| - CHECK_EQ(1, weakmap->table()->NumberOfElements()); |
| - CHECK_EQ(0, weakmap->table()->NumberOfDeletedElements()); |
| + CHECK_EQ(1, ObjectHashTable::cast(weakmap->table())->NumberOfElements()); |
| + CHECK_EQ(0, ObjectHashTable::cast(weakmap->table())-> |
| + NumberOfDeletedElements()); |
|
Rico
2011/10/04 16:27:53
I don't like this indention or the fact that we en
|
| // Make the global reference to the key weak. |
| { |
| @@ -107,12 +108,14 @@ TEST(Weakness) { |
| // weak references whereas the second one will also clear weak maps. |
| HEAP->CollectAllGarbage(false); |
| CHECK_EQ(1, NumberOfWeakCalls); |
| - CHECK_EQ(1, weakmap->table()->NumberOfElements()); |
| - CHECK_EQ(0, weakmap->table()->NumberOfDeletedElements()); |
| + CHECK_EQ(1, ObjectHashTable::cast(weakmap->table())->NumberOfElements()); |
| + CHECK_EQ(0, ObjectHashTable::cast(weakmap->table())-> |
| + NumberOfDeletedElements()); |
| HEAP->CollectAllGarbage(false); |
| CHECK_EQ(1, NumberOfWeakCalls); |
| - CHECK_EQ(0, weakmap->table()->NumberOfElements()); |
| - CHECK_EQ(1, weakmap->table()->NumberOfDeletedElements()); |
| + CHECK_EQ(0, ObjectHashTable::cast(weakmap->table())->NumberOfElements()); |
| + CHECK_EQ(1, ObjectHashTable::cast(weakmap->table())-> |
| + NumberOfDeletedElements()); |
| } |
| @@ -122,7 +125,7 @@ TEST(Shrinking) { |
| Handle<JSWeakMap> weakmap = AllocateJSWeakMap(); |
| // Check initial capacity. |
| - CHECK_EQ(32, weakmap->table()->Capacity()); |
| + CHECK_EQ(32, ObjectHashTable::cast(weakmap->table())->Capacity()); |
| // Fill up weak map to trigger capacity change. |
| { |
| @@ -135,15 +138,17 @@ TEST(Shrinking) { |
| } |
| // Check increased capacity. |
| - CHECK_EQ(128, weakmap->table()->Capacity()); |
| + CHECK_EQ(128, ObjectHashTable::cast(weakmap->table())->Capacity()); |
| // Force a full GC. |
| - CHECK_EQ(32, weakmap->table()->NumberOfElements()); |
| - CHECK_EQ(0, weakmap->table()->NumberOfDeletedElements()); |
| + CHECK_EQ(32, ObjectHashTable::cast(weakmap->table())->NumberOfElements()); |
| + CHECK_EQ(0, ObjectHashTable::cast(weakmap->table())-> |
| + NumberOfDeletedElements()); |
| HEAP->CollectAllGarbage(false); |
| - CHECK_EQ(0, weakmap->table()->NumberOfElements()); |
| - CHECK_EQ(32, weakmap->table()->NumberOfDeletedElements()); |
| + CHECK_EQ(0, ObjectHashTable::cast(weakmap->table())->NumberOfElements()); |
| + CHECK_EQ(32, ObjectHashTable::cast(weakmap->table())-> |
| + NumberOfDeletedElements()); |
| // Check shrunk capacity. |
| - CHECK_EQ(32, weakmap->table()->Capacity()); |
| + CHECK_EQ(32, ObjectHashTable::cast(weakmap->table())->Capacity()); |
| } |