Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 8136004: Fix compilation error and add missing file to GYP. (Closed)

Created:
9 years, 2 months ago by Michael Starzinger
Modified:
9 years, 2 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Fix compilation error and add missing file to GYP. R=ricow@chromium.org Commited: http://code.google.com/p/v8/source/detail?r=9518

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments by Rico Wind. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-weakmaps.cc View 1 5 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Starzinger
9 years, 2 months ago (2011-10-04 16:22:56 UTC) #1
Rico
LGTM with small nit http://codereview.chromium.org/8136004/diff/1/test/cctest/test-weakmaps.cc File test/cctest/test-weakmaps.cc (right): http://codereview.chromium.org/8136004/diff/1/test/cctest/test-weakmaps.cc#newcode95 test/cctest/test-weakmaps.cc:95: NumberOfDeletedElements()); I don't like this ...
9 years, 2 months ago (2011-10-04 16:27:53 UTC) #2
Rico
LGTM with small nit
9 years, 2 months ago (2011-10-04 16:27:54 UTC) #3
Rico
LGTM with small nit
9 years, 2 months ago (2011-10-04 16:27:55 UTC) #4
Michael Starzinger
Added new patch set.
9 years, 2 months ago (2011-10-04 16:32:46 UTC) #5
Rico
9 years, 2 months ago (2011-10-04 17:02:08 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698