chrome/browser/browsing_data_remover.cc - Issue 8135017: Refactor downloads into a ProfileKeyedService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data_remover.cc

Issue 8135017: Refactor downloads into a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated latest rounds of comments from John. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browsing_data_remover.cc

diff --git a/chrome/browser/browsing_data_remover.cc b/chrome/browser/browsing_data_remover.cc

index 0cfc15d0363a6f4ebf77466f3ea60dd986446fd6..f7f831af19cb88971c05af3d2326a126c59a0900 100644

--- a/chrome/browser/browsing_data_remover.cc

+++ b/chrome/browser/browsing_data_remover.cc

@@ -16,6 +16,8 @@

#include "chrome/browser/autofill/personal_data_manager.h"

#include "chrome/browser/autofill/personal_data_manager_factory.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/browser/download/download_service.h"

+#include "chrome/browser/download/download_service_factory.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_special_storage_policy.h"

#include "chrome/browser/history/history.h"

@@ -193,7 +195,8 @@ void BrowsingDataRemover::Remove(int remove_mask) {

if (remove_mask & REMOVE_DOWNLOADS) {

UserMetrics::RecordAction(UserMetricsAction("ClearBrowsingData_Downloads"));

- DownloadManager* download_manager = profile_->GetDownloadManager();

+ DownloadManager* download_manager =

+ DownloadServiceFactory::GetForProfile(profile_)->GetDownloadManager();

download_manager->RemoveDownloadsBetween(delete_begin_, delete_end_);

download_manager->ClearLastDownloadPath();

}