Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.h

Issue 8135017: Refactor downloads into a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data_remover.cc ('k') | chrome/browser/download/download_browsertest.cc » ('j') | chrome/browser/profiles/profile_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/chrome_download_manager_delegate.h
diff --git a/chrome/browser/download/chrome_download_manager_delegate.h b/chrome/browser/download/chrome_download_manager_delegate.h
index b006e5396ded660c75780eb53b606a3a6991eff0..2229089d80a41ddb70efc7cf07ed8917a80951f9 100644
--- a/chrome/browser/download/chrome_download_manager_delegate.h
+++ b/chrome/browser/download/chrome_download_manager_delegate.h
@@ -44,11 +44,11 @@ class ChromeDownloadManagerDelegate
public:
explicit ChromeDownloadManagerDelegate(Profile* profile);
+ virtual void SetDownloadManager(DownloadManager* dm);
jam 2011/10/11 19:31:13 nit: not virtual
Randy Smith (Not in Mondays) 2011/10/11 20:28:27 Done.
+
// Returns true if the given item is for an extension download.
static bool IsExtensionDownload(const DownloadItem* item);
- void SetDownloadManager(DownloadManager* dm);
-
virtual void Shutdown() OVERRIDE;
virtual bool ShouldStartDownload(int32 download_id) OVERRIDE;
virtual void ChooseDownloadPath(TabContents* tab_contents,
« no previous file with comments | « chrome/browser/browsing_data_remover.cc ('k') | chrome/browser/download/download_browsertest.cc » ('j') | chrome/browser/profiles/profile_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698