Refactor downloads into a ProfileKeyedService.

content/browser/download/download_manager.h

Index: content/browser/download/download_manager.h
diff --git a/content/browser/download/download_manager.h b/content/browser/download/download_manager.h
index 822c1f7d24911aef5791bafada80308dbe078e16..f4b47fc095919cc3c690872cbb1a94735b7ce3b4 100644
--- a/content/browser/download/download_manager.h
+++ b/content/browser/download/download_manager.h
@@ -294,22 +294,23 @@ class CONTENT_EXPORT DownloadManager
 
   DownloadManagerDelegate* delegate() const { return delegate_; }
 
+  // For testing only.
+  void SetDownloadManagerDelegate(DownloadManagerDelegate* delegate);

[jam, 2011/10/10 18:19:33]

nit: please add a "ForTesting" suffix. we have presubmit checks that ensure that
they're only called by test code.

[Miranda Callahan, 2011/10/11 14:53:03]

Whoa, I didn't know that we had a presubmit check for that -- that's great! I
added a line to the Chromium style guide on naming to make that clear.

[Randy Smith (Not in Mondays), 2011/10/11 18:24:43]

Can I convince you to rescind this request?  The problem is that I want to keep
the delegates in sync between DownloadService and DownloadManager, and so I call
DownloadManager::SetDownloadManagerDelegate(ForTesting :-}) from
DownloadService::SetDownloadManagerDelegateForTesting.  I can (and will) change
the name of the DownloadService call, but I'm already having to make the test
code wonkier and more prone to error than I'd like (see response to other
comment), and I'd rather have DownloadService call the DownloadManager version. 

[jam, 2011/10/11 19:31:13]

sure, sounds reasonable. ideally, the presubmit check wouldn't count calls from
other ForTest functions :)

+
  private:
   typedef std::set<DownloadItem*> DownloadSet;
   typedef base::hash_map<int64, DownloadItem*> DownloadMap;
 
   // For testing.
   friend class DownloadManagerTest;
-  friend class MockDownloadManager;
   friend class DownloadTest;
+  friend class MockDownloadManager;
 
   friend class base::RefCountedThreadSafe<DownloadManager,
                                           BrowserThread::DeleteOnUIThread>;
   friend struct BrowserThread::DeleteOnThread<BrowserThread::UI>;
   friend class DeleteTask<DownloadManager>;
 
-  void set_delegate(DownloadManagerDelegate* delegate) { delegate_ = delegate; }
-
   virtual ~DownloadManager();
 
   // Called on the FILE thread to check the existence of a downloaded file.