Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: chrome/browser/download/download_service.cc

Issue 8135017: Refactor downloads into a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged to LKGR to run try bots. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_service.cc
diff --git a/chrome/browser/download/download_service.cc b/chrome/browser/download/download_service.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1e149afe8a1534ececd2f768b1258a1ea16bc15f
--- /dev/null
+++ b/chrome/browser/download/download_service.cc
@@ -0,0 +1,59 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/download/download_service.h"
+
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/download/chrome_download_manager_delegate.h"
+#include "chrome/browser/profiles/profile.h"
+#include "content/browser/download/download_manager.h"
+
+DownloadService::DownloadService(Profile* profile)
+ : download_manager_created_(false),
+ profile_(profile) {}
+
+DownloadService::~DownloadService() {}
+
+DownloadManager* DownloadService::GetDownloadManager() {
+ if (!download_manager_created_) {
+ // In case the delegate has already been set by SetDownloadManagerDelegate.
+ if (!manager_delegate_.get())
+ manager_delegate_ = new ChromeDownloadManagerDelegate(profile_);
+ manager_ = new DownloadManager(
+ manager_delegate_.get(), g_browser_process->download_status_updater());
+ manager_->Init(profile_);
+ manager_delegate_->SetDownloadManager(manager_);
+ download_manager_created_ = true;
+ }
+ return manager_.get();
+}
+
+bool DownloadService::HasCreatedDownloadManager() {
+ return download_manager_created_;
+}
+
+void DownloadService::SetDownloadManagerDelegate(
+ ChromeDownloadManagerDelegate* new_delegate) {
+ manager_->set_delegate(new_delegate);
+ new_delegate->SetDownloadManager(manager_);
+ manager_delegate_ = new_delegate;
+}
+
+void DownloadService::Shutdown() {
+ if (manager_.get()) {
+ manager_->Shutdown();
+
+ // The manager reference can be released any time after shutdown;
+ // it will be destroyed when the last reference is released on the
+ // FILE thread.
+ // Resetting here will guarantee that any attempts to get the
+ // DownloadManager after shutdown will return null.
+ //
+ // TODO(rdsmith): Figure out how to guarantee when the last reference
+ // will be released and make DownloadManager not RefCountedThreadSafe<>.
+ manager_.release();
+ }
+ if (manager_delegate_.get())
+ manager_delegate_.release();
+}

Powered by Google App Engine
This is Rietveld 408576698