Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8135009: [Multi profile] Clicking "Customize User" should show the "Manage User" dialog. (Closed)

Created:
9 years, 2 months ago by binji
Modified:
9 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[Multi profile] Clicking "Customize User" should show the "Manage User" dialog. BUG=92373 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104159

Patch Set 1 #

Patch Set 2 : " #

Total comments: 6

Patch Set 3 : " #

Patch Set 4 : " #

Total comments: 1

Patch Set 5 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -15 lines) Patch
M chrome/browser/profiles/avatar_menu_model.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 2 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.h View 1 2 3 2 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 3 4 7 chunks +44 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
binji
jhawkins: review sail: fyi
9 years, 2 months ago (2011-10-04 20:26:01 UTC) #1
sail
LGTM Thanks for doing this!
9 years, 2 months ago (2011-10-04 20:31:21 UTC) #2
sail
LGTM Thanks for doing this!
9 years, 2 months ago (2011-10-04 20:31:22 UTC) #3
James Hawkins
http://codereview.chromium.org/8135009/diff/2001/chrome/browser/ui/webui/options/manage_profile_handler.cc File chrome/browser/ui/webui/options/manage_profile_handler.cc (right): http://codereview.chromium.org/8135009/diff/2001/chrome/browser/ui/webui/options/manage_profile_handler.cc#newcode139 chrome/browser/ui/webui/options/manage_profile_handler.cc:139: DictionaryValue profile_value; DCHECK(args); http://codereview.chromium.org/8135009/diff/2001/chrome/browser/ui/webui/options/manage_profile_handler.cc#newcode151 chrome/browser/ui/webui/options/manage_profile_handler.cc:151: if (index < 0 ...
9 years, 2 months ago (2011-10-04 20:33:42 UTC) #4
binji
http://codereview.chromium.org/8135009/diff/2001/chrome/browser/ui/webui/options/manage_profile_handler.cc File chrome/browser/ui/webui/options/manage_profile_handler.cc (right): http://codereview.chromium.org/8135009/diff/2001/chrome/browser/ui/webui/options/manage_profile_handler.cc#newcode139 chrome/browser/ui/webui/options/manage_profile_handler.cc:139: DictionaryValue profile_value; On 2011/10/04 20:33:42, James Hawkins wrote: > ...
9 years, 2 months ago (2011-10-04 21:39:56 UTC) #5
James Hawkins
LGTM with nit. http://codereview.chromium.org/8135009/diff/16/chrome/browser/ui/webui/options/manage_profile_handler.cc File chrome/browser/ui/webui/options/manage_profile_handler.cc (right): http://codereview.chromium.org/8135009/diff/16/chrome/browser/ui/webui/options/manage_profile_handler.cc#newcode76 chrome/browser/ui/webui/options/manage_profile_handler.cc:76: DCHECK(args); I don't see |args| being ...
9 years, 2 months ago (2011-10-04 22:05:39 UTC) #6
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/8135009/6003
9 years, 2 months ago (2011-10-05 18:12:19 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-10-05 19:46:45 UTC) #8 
Change committed as 104159

Powered by Google App Engine
This is Rietveld 408576698