Issue 8135007: Improve logging and ease debugging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8135007: Improve logging and ease debugging. (Closed)

Created:
9 years, 2 months ago by M-A Ruel

Modified:
9 years, 2 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Improve logging and ease debugging. While trying to fix all the multithreading issues... R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104026

Patch Set 2 : address review comments #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -35 lines)			Patch
M	gclient.py	View	1	6 chunks	+27 lines, -25 lines	0 comments	Download
M	gclient_utils.py	View	1	6 chunks	+10 lines, -8 lines	0 comments	Download
M	tests/gclient_test.py	View	1	4 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

lgtm w/ nits. http://codereview.chromium.org/8135007/diff/1/gclient.py File gclient.py (right): http://codereview.chromium.org/8135007/diff/1/gclient.py#newcode379 gclient.py:379: raise gclient_utils.Error('Unkown url type') Nit: typo ...

9 years, 2 months ago (2011-10-04 22:14:13 UTC) #2

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8135007/4002

9 years, 2 months ago (2011-10-04 23:34:07 UTC) #3

Change committed as 104026

Expand Messages | Collapse Messages

Issue 8135007: Improve logging and ease debugging. (Closed)

Description

Patch Set 1 #

Patch Set 2 : address review comments #

Messages