Issue 8135006: Fix yet another crash in ProxyResolutionService with debug build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8135006: Fix yet another crash in ProxyResolutionService with debug build. (Closed)

Created:
9 years, 2 months ago by satorux1

Modified:
9 years, 2 months ago

Reviewers:
stevenjb, commit-bot: I haz the power

CC:
chromium-reviews, stevenjb, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix yet another crash in ProxyResolutionService with debug build. GetRequestContext() must be called on the UI thread. Otherwise, DCHECK() will fail. TEST=confirm that the crash is gone. BUG=chromium-os:21209 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104065

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc	View		3 chunks	+7 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8135006/1

9 years, 2 months ago (2011-10-05 03:41:21 UTC) #3

Change committed as 104065