Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6659)

Unified Diff: chrome/browser/ui/browser.cc

Issue 8135001: Fixed behavior of the bookmark bar visibility. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reviewed, rebased Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 67a532374ce145d6e0b6df88a879d50592e204e3..e3cbae6295ee2bca451262358e0d292172e1234d 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -325,7 +325,7 @@ Browser::Browser(Type type, Profile* profile)
profile_pref_registrar_.Init(profile_->GetPrefs());
profile_pref_registrar_.Add(prefs::kDevToolsDisabled, this);
profile_pref_registrar_.Add(prefs::kEditBookmarksEnabled, this);
- profile_pref_registrar_.Add(prefs::kEnableBookmarkBar, this);
+ profile_pref_registrar_.Add(prefs::kShowBookmarkBar, this);
profile_pref_registrar_.Add(prefs::kHomePage, this);
profile_pref_registrar_.Add(prefs::kInstantEnabled, this);
profile_pref_registrar_.Add(prefs::kIncognitoModeAvailability, this);
@@ -2297,9 +2297,6 @@ void Browser::RegisterUserPrefs(PrefService* prefs) {
prefs->RegisterBooleanPref(prefs::kEnableTranslate,
true,
PrefService::SYNCABLE_PREF);
- prefs->RegisterBooleanPref(prefs::kEnableBookmarkBar,
- true,
- PrefService::UNSYNCABLE_PREF);
prefs->RegisterStringPref(prefs::kCloudPrintEmail,
std::string(),
PrefService::UNSYNCABLE_PREF);
@@ -4111,7 +4108,7 @@ void Browser::Observe(int type,
g_browser_process->devtools_manager()->CloseAllClientHosts();
} else if (pref_name == prefs::kEditBookmarksEnabled) {
UpdateCommandsForBookmarkEditing();
- } else if (pref_name == prefs::kEnableBookmarkBar) {
+ } else if (pref_name == prefs::kShowBookmarkBar) {
UpdateCommandsForBookmarkBar();
} else if (pref_name == prefs::kHomePage) {
PrefService* pref_service = Source<PrefService>(source).ptr();
@@ -4575,7 +4572,7 @@ void Browser::UpdateCommandsForBookmarkBar() {
#endif
command_updater_.UpdateCommandEnabled(IDC_SHOW_BOOKMARK_BAR,
browser_defaults::bookmarks_enabled &&
- !profile_->GetPrefs()->IsManagedPreference(prefs::kEnableBookmarkBar) &&
+ !profile_->GetPrefs()->IsManagedPreference(prefs::kShowBookmarkBar) &&
show_main_ui);
}
@@ -5228,8 +5225,7 @@ int Browser::GetContentRestrictionsForSelectedTab() {
void Browser::UpdateBookmarkBarState(BookmarkBarStateChangeReason reason) {
BookmarkBar::State state;
// The bookmark bar is hidden in fullscreen mode, unless on the new tab page.
- if ((profile_->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar) &&
- profile_->GetPrefs()->GetBoolean(prefs::kEnableBookmarkBar)) &&
+ if (profile_->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar) &&
(!window_ || !window_->IsFullscreen())) {
state = BookmarkBar::SHOW;
} else {

Powered by Google App Engine
This is Rietveld 408576698