Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/browser/ui/gtk/global_menu_bar.h

Issue 8135001: Fixed behavior of the bookmark bar visibility. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DCHECK_EQ instead of DCHECK Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm ('k') | chrome/browser/ui/gtk/global_menu_bar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/global_menu_bar.h
diff --git a/chrome/browser/ui/gtk/global_menu_bar.h b/chrome/browser/ui/gtk/global_menu_bar.h
index 82212baee2fed225afeb0f7beeec7face795035b..caac22242127f5cb18846ef6eec6f801de454d2f 100644
--- a/chrome/browser/ui/gtk/global_menu_bar.h
+++ b/chrome/browser/ui/gtk/global_menu_bar.h
@@ -7,15 +7,16 @@
#include <map>
+#include "base/memory/scoped_ptr.h"
#include "chrome/browser/command_updater.h"
-#include "chrome/browser/ui/gtk/global_bookmark_menu.h"
+#include "chrome/browser/prefs/pref_change_registrar.h"
#include "chrome/browser/ui/gtk/global_history_menu.h"
#include "content/common/notification_observer.h"
-#include "content/common/notification_registrar.h"
#include "ui/base/gtk/gtk_signal.h"
#include "ui/base/gtk/owned_widget_gtk.h"
class Browser;
+class GlobalBookmarkMenu;
struct GlobalMenuBarCommand;
class GlobalMenuOwner;
@@ -73,11 +74,15 @@ class GlobalMenuBar : public CommandUpdater::CommandObserver,
const NotificationSource& source,
const NotificationDetails& details);
+ // Updates the visibility of the bookmark bar on pref changes.
+ void OnBookmarkBarVisibilityChanged();
+
CHROMEGTK_CALLBACK_0(GlobalMenuBar, void, OnItemActivated);
Browser* browser_;
- NotificationRegistrar registrar_;
+ // Tracks value of the kShowBookmarkBar preference.
+ PrefChangeRegistrar pref_change_registrar_;
// Our menu bar widget.
ui::OwnedWidgetGtk menu_bar_;
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm ('k') | chrome/browser/ui/gtk/global_menu_bar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698