Fixed behavior of the bookmark bar visibility.

chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_util.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
 #include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/pref_names.h"
+#include "content/common/notification_details.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // A BrowserWindowCocoa that goes PONG when
 // BOOKMARK_BAR_VISIBILITY_PREF_CHANGED is sent.  This is so we can be
 // sure we are observing it.
 class BrowserWindowCocoaPong : public BrowserWindowCocoa {
  public:
   BrowserWindowCocoaPong(Browser* browser,
                          BrowserWindowController* controller)
       : BrowserWindowCocoa(browser, controller) {
     pong_ = false;
   }
   virtual ~BrowserWindowCocoaPong() { }
 
   void Observe(int type,
                const NotificationSource& source,
                const NotificationDetails& details) {
-    if (type == chrome::NOTIFICATION_BOOKMARK_BAR_VISIBILITY_PREF_CHANGED)
-      pong_ = true;
+    if (type == chrome::NOTIFICATION_PREF_CHANGED) {
+      const std::string& pref_name = *Details<std::string>(details).ptr();
+      if (pref_name == prefs::kShowBookmarkBar)
+        pong_ = true;
+    }
     BrowserWindowCocoa::Observe(type, source, details);
   }
 
   bool pong_;
 };
 
 // Main test class.
 class BrowserWindowCocoaTest : public CocoaProfileTest {
   virtual void SetUp() {
     CocoaProfileTest::SetUp();
@@ skipping 68 matching lines @@
 
   EXPECT_FALSE(bwc->IsFullscreen());
   bwc->SetFullscreen(true);
   EXPECT_TRUE(bwc->IsFullscreen());
   bwc->SetFullscreen(false);
   EXPECT_FALSE(bwc->IsFullscreen());
   [fake_controller close];
 }
 
 // TODO(???): test other methods of BrowserWindowCocoa