Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 8133032: Fix git try --upstream_branch breakage due to removal of |file_list| param. (Closed)

Created:
9 years, 2 months ago by Alexei Svitkine (slow)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel, Bernhard Bauer
Visibility:
Public.

Description

Fix git --upstream_branch breakage due to removal of |file_list| param. Makes SCM take the |file_list| as a parameter instead of getting it from |options|. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104148

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M tests/trychange_unittest.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M trychange.py View 1 8 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
9 years, 2 months ago (2011-10-05 18:52:22 UTC) #1
M-A Ruel
lgtm http://codereview.chromium.org/8133032/diff/2001/trychange.py File trychange.py (right): http://codereview.chromium.org/8133032/diff/2001/trychange.py#newcode687 trychange.py:687: file_list = [] Can you add a comment ...
9 years, 2 months ago (2011-10-05 19:03:12 UTC) #2
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8133032/7001
9 years, 2 months ago (2011-10-05 19:05:48 UTC) #3
commit-bot: I haz the power
Presubmit check for 8133032-7001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 2 months ago (2011-10-05 19:11:52 UTC) #4
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8133032/8002
9 years, 2 months ago (2011-10-05 19:14:49 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-05 19:20:56 UTC) #6
Change committed as 104148

Powered by Google App Engine
This is Rietveld 408576698