Issue 8133029: Merge 96628 - REGRESSION(r94274): setting input.value erroneously triggers focus event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8133029: Merge 96628 - REGRESSION(r94274): setting input.value erroneously triggers focus event (Closed)

Created:
9 years, 2 months ago by rniwa-cr

Modified:
9 years, 2 months ago

Reviewers:
rniwa

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/

Visibility:
Public.

Description

Merge 96628 - REGRESSION(r94274): setting input.value erroneously triggers focus event https://bugs.webkit.org/show_bug.cgi?id=69315 Reviewed by Kent Tamura. Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded when called by nodeWillBeRemoved and textWillBeReplaced. Added a manual test. Unfortunately, the test always passes in DRT. * editing/FrameSelection.cpp: (WebCore::FrameSelection::setSelection): (WebCore::FrameSelection::respondToNodeModification): (WebCore::FrameSelection::textWillBeReplaced): * editing/FrameSelection.h: * manual-tests/mutate-unfocused-text-with-selection.html: Added. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96734

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -2 lines)			Patch
M	Source/WebCore/editing/FrameSelection.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebCore/editing/FrameSelection.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A +	Source/WebCore/manual-tests/mutate-unfocused-text-with-selection.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages