Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8133029: Merge 96628 - REGRESSION(r94274): setting input.value erroneously triggers focus event (Closed)

Created:
9 years, 2 months ago by rniwa-cr
Modified:
9 years, 2 months ago
Reviewers:
rniwa
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 96628 - REGRESSION(r94274): setting input.value erroneously triggers focus event https://bugs.webkit.org/show_bug.cgi?id=69315 Reviewed by Kent Tamura. Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded when called by nodeWillBeRemoved and textWillBeReplaced. Added a manual test. Unfortunately, the test always passes in DRT. * editing/FrameSelection.cpp: (WebCore::FrameSelection::setSelection): (WebCore::FrameSelection::respondToNodeModification): (WebCore::FrameSelection::textWillBeReplaced): * editing/FrameSelection.h: * manual-tests/mutate-unfocused-text-with-selection.html: Added. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/WebCore/editing/FrameSelection.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/editing/FrameSelection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A + Source/WebCore/manual-tests/mutate-unfocused-text-with-selection.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rniwa-cr
9 years, 2 months ago (2011-10-05 18:29:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698