Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic.cc

Issue 8133020: Simplify calling generated code from the runtime. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2384 matching lines...) Expand 10 before | Expand all | Expand 10 after
2395 case Token::SHL: 2395 case Token::SHL:
2396 builtin = builtins->javascript_builtin(Builtins::SHL); 2396 builtin = builtins->javascript_builtin(Builtins::SHL);
2397 break; 2397 break;
2398 default: 2398 default:
2399 UNREACHABLE(); 2399 UNREACHABLE();
2400 } 2400 }
2401 2401
2402 Handle<JSFunction> builtin_function(JSFunction::cast(builtin), isolate); 2402 Handle<JSFunction> builtin_function(JSFunction::cast(builtin), isolate);
2403 2403
2404 bool caught_exception; 2404 bool caught_exception;
2405 Object** builtin_args[] = { right.location() }; 2405 Handle<Object> builtin_args[] = { right };
rossberg 2011/10/05 13:10:17 Nit: I think you used argv everywhere else.
2406 Handle<Object> result = Execution::Call(builtin_function, 2406 Handle<Object> result = Execution::Call(builtin_function,
2407 left, 2407 left,
2408 ARRAY_SIZE(builtin_args), 2408 ARRAY_SIZE(builtin_args),
2409 builtin_args, 2409 builtin_args,
2410 &caught_exception); 2410 &caught_exception);
2411 if (caught_exception) { 2411 if (caught_exception) {
2412 return Failure::Exception(); 2412 return Failure::Exception();
2413 } 2413 }
2414 return *result; 2414 return *result;
2415 } 2415 }
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
2508 #undef ADDR 2508 #undef ADDR
2509 }; 2509 };
2510 2510
2511 2511
2512 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2512 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2513 return IC_utilities[id]; 2513 return IC_utilities[id];
2514 } 2514 }
2515 2515
2516 2516
2517 } } // namespace v8::internal 2517 } } // namespace v8::internal
OLDNEW
« src/execution.cc ('K') | « src/factory.cc ('k') | src/jsregexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698