Simplify calling generated code from the runtime.

Simplify calling generated code from the runtime.

Instead of expecting Object** arrays at the outermost level, expect
Handle<Object> arrays and reinterpret_cast them only just before invoking
the generated code.

R=rossberg@chromium.org,fschneider@chromium.org
BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=9537

[rossberg, 2011-10-05 13:10:17]

LGTM

Glad you did this!

http://codereview.chromium.org/8133020/diff/1/src/execution.cc
File src/execution.cc (right):

http://codereview.chromium.org/8133020/diff/1/src/execution.cc#newcode582
src/execution.cc:582: ARRAY_SIZE(argv), argv,                                 \
I guess it doesn't matter much, because the macro is only used locally, but
isn't this a bit dangerous? Does it give a compile time error if somebody tries
to invoke the macro with args not being a static array?

http://codereview.chromium.org/8133020/diff/1/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/8133020/diff/1/src/ic.cc#newcode2405
src/ic.cc:2405: Handle<Object> builtin_args[] = { right };
Nit: I think you used argv everywhere else.

[Kevin Millikin (Chromium), 2011-10-05 13:47:26]

http://codereview.chromium.org/8133020/diff/1/src/execution.cc
File src/execution.cc (right):

http://codereview.chromium.org/8133020/diff/1/src/execution.cc#newcode582
src/execution.cc:582: ARRAY_SIZE(argv), argv,                                 \
Yeah, it's a bit dangerous and the programmer has to be careful.

It was also a bit dangerous to have the named constants and magic numbers that
had to agree with the arg count before, though.