More stubbing out. With this and the rest of Linux pending, test_shell links.

More stubbing out. With this and the rest of Linux pending, test_shell links.

There doesn't appear to be a WebKit PLATFORM macro for LINUX and, since we're
in the middle of a merge, adding one isn't a great idea either. So I'm using
__linux__ here. Also, several the stubs were very temporary and since stubbing
them required getting their headers to work as well I just aliased them away.

[Evan Martin, 2008-10-24 01:14:14]

http://codereview.chromium.org/8131/diff/1/3
File webkit/glue/SConscript (right):

http://codereview.chromium.org/8131/diff/1/3#newcode72
Line 72: if env['PLATFORM'] == 'posix':
Please doc with a TODO(port) if this is intended to be temporary

http://codereview.chromium.org/8131/diff/1/4
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/8131/diff/1/4#newcode374
Line 374: #if !defined(__linux__)
Since OS X doesn't compile this anyway, can this be
PLATFORM(UNIX)
?

Also with a TODO(port)

http://codereview.chromium.org/8131/diff/1/5
File webkit/port/bridge/chromium/PluginsChromium.cpp (right):

http://codereview.chromium.org/8131/diff/1/5#newcode147
Line 147: #if !defined(__linux__)
same here

http://codereview.chromium.org/8131/diff/1/8
File webkit/port/platform/chromium/TemporaryLinkStubs.cpp (right):

http://codereview.chromium.org/8131/diff/1/8#newcode55
Line 55: #if !defined(__linux__)
Why does this one need to be hidden?

http://codereview.chromium.org/8131/diff/1/12
File webkit/tools/test_shell/gtk/test_shell.cc (right):

http://codereview.chromium.org/8131/diff/1/12#newcode195
Line 195: // things linking
Can you note which functions?  Just the Cookie ones?

http://codereview.chromium.org/8131/diff/1/12#newcode206
Line 206: // soon. Thus we just alias them to an asserting function.
Dude, this is total crack and you know it.  Let's figure out something else.

[Evan Martin, 2008-10-24 01:19:04]

Checkout TemporaryLinkStubs.cpp used in this:
http://codereview.chromium.org/8116

Can we get away with that?

[Evan Martin, 2008-10-24 03:04:44]

http://codereview.chromium.org/8061/show

[agl, 2008-10-24 05:16:53]

http://codereview.chromium.org/8131/diff/1/3
File webkit/glue/SConscript (right):

http://codereview.chromium.org/8131/diff/1/3#newcode72
Line 72: if env['PLATFORM'] == 'posix':
On 2008/10/24 01:14:15, Evan Martin wrote:
> Please doc with a TODO(port) if this is intended to be temporary

Done.

http://codereview.chromium.org/8131/diff/1/4
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/8131/diff/1/4#newcode374
Line 374: #if !defined(__linux__)
On 2008/10/24 01:14:15, Evan Martin wrote:
> Since OS X doesn't compile this anyway, can this be
> PLATFORM(UNIX)

But I believe that OSX does compile them. I can't see any reason in the SCons
files that it shouldn't.

> Also with a TODO(port)

Done.

http://codereview.chromium.org/8131/diff/1/5
File webkit/port/bridge/chromium/PluginsChromium.cpp (right):

http://codereview.chromium.org/8131/diff/1/5#newcode147
Line 147: #if !defined(__linux__)
On 2008/10/24 01:14:15, Evan Martin wrote:
> same here

ack.

http://codereview.chromium.org/8131/diff/1/8
File webkit/port/platform/chromium/TemporaryLinkStubs.cpp (right):

http://codereview.chromium.org/8131/diff/1/8#newcode55
Line 55: #if !defined(__linux__)
On 2008/10/24 01:14:15, Evan Martin wrote:
> Why does this one need to be hidden?

Otherwise we get a duplicate symbol with test_shell. Other function in
third_party/WebKit/JavaScriptCore/wtf/gtk/MainThreadGtk.cpp

http://codereview.chromium.org/8131/diff/1/12
File webkit/tools/test_shell/gtk/test_shell.cc (right):

http://codereview.chromium.org/8131/diff/1/12#newcode195
Line 195: // things linking
On 2008/10/24 01:14:15, Evan Martin wrote:
> Can you note which functions?  Just the Cookie ones?

Done.

http://codereview.chromium.org/8131/diff/1/12#newcode206
Line 206: // soon. Thus we just alias them to an asserting function.
On 2008/10/24 01:14:15, Evan Martin wrote:
> Dude, this is total crack and you know it.  Let's figure out something else.

It happens that the Mac folks just did half of these anyway. It's still a waste
of time to stub out functions that are going away next week, but since it's
already done, this section has been zapped.

[Evan Martin, 2008-10-24 20:51:10]

LGTM