src/objects.cc - Issue 8130002: Make accessors for oddball objects return Oddball* instead of Object*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 8130002: Make accessors for oddball objects return Oddball* instead of Object*. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: split InitializeThreadLocal into two parts Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

===================================================================

--- src/objects.cc (revision 9511)

+++ src/objects.cc (working copy)

@@ -545,7 +545,9 @@

// holder in the prototype chain.

// Proxy handlers do not use the proxy's prototype, so we can skip this.

if (!result->IsHandler()) {

- Object* last = result->IsProperty() ? result->holder() : heap->null_value();

+ Object* last = result->IsProperty()

+ ? result->holder()

+ : Object::cast(heap->null_value());

ASSERT(this != this->GetPrototype());

for (Object* current = this; true; current = current->GetPrototype()) {

if (current->IsAccessCheckNeeded()) {

« no previous file with comments | « src/objects.h ('k') | src/type-info.h » ('j') | no next file with comments »