Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: src/debug.cc

Issue 8130002: Make accessors for oddball objects return Oddball* instead of Object*. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/heap.h » ('j') | src/heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
===================================================================
--- src/debug.cc (revision 9511)
+++ src/debug.cc (working copy)
@@ -2158,8 +2158,8 @@
const int argc = 3;
Object** argv[argc] = { exec_state.location(),
exception.location(),
- uncaught ? factory->true_value().location() :
- factory->false_value().location()};
+ reinterpret_cast<Object**>(uncaught ? factory->true_value().location() :
Vyacheslav Egorov (Chromium) 2011/10/04 11:00:51 line is too long, also consider making Factory::To
fschneider 2011/10/04 11:28:16 Done.
+ factory->false_value().location())};
return MakeJSObject(CStrVector("MakeExceptionEvent"),
argc, argv, caught_exception);
}
@@ -2185,8 +2185,8 @@
const int argc = 3;
Object** argv[argc] = { exec_state.location(),
script_wrapper.location(),
- before ? factory->true_value().location() :
- factory->false_value().location() };
+ reinterpret_cast<Object**>(before ? factory->true_value().location() :
Vyacheslav Egorov (Chromium) 2011/10/04 11:00:51 line is too long, also consider making Factory::To
fschneider 2011/10/04 11:28:16 Done.
+ factory->false_value().location()) };
return MakeJSObject(CStrVector("MakeCompileEvent"),
argc,
« no previous file with comments | « src/compiler.cc ('k') | src/heap.h » ('j') | src/heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698