src/type-info.cc - Issue 8130002: Make accessors for oddball objects return Oddball* instead of Object*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.cc

Issue 8130002: Make accessors for oddball objects return Oddball* instead of Object*. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/type-info.cc

===================================================================

--- src/type-info.cc (revision 9511)

+++ src/type-info.cc (working copy)

@@ -60,8 +60,10 @@

TypeFeedbackOracle::TypeFeedbackOracle(Handle<Code> code,

- Handle<Context> global_context) {

+ Handle<Context> global_context,

+ Isolate* isolate) {

global_context_ = global_context;

+ isolate_ = isolate;

BuildDictionary(code);

ASSERT(reinterpret_cast<Address>(*dictionary_.location()) != kHandleZapValue);

}

@@ -71,7 +73,7 @@

int entry = dictionary_->FindEntry(ast_id);

return entry != NumberDictionary::kNotFound

? Handle<Object>(dictionary_->ValueAt(entry))

- : Isolate::Current()->factory()->undefined_value();

+ : Handle<Object>::cast(Isolate::Current()->factory()->undefined_value());

Vyacheslav Egorov (Chromium) 2011/10/04 11:00:51 you have isolate_ now

fschneider 2011/10/04 11:28:16 Done. Of course, I totally forgot about that :)

}

« src/isolate.cc ('K') | « src/type-info.h ('k') | src/v8utils.h » ('j') | src/v8utils.h » ('J')