Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: src/messages.cc

Issue 8130002: Make accessors for oddball objects return Oddball* instead of Object*. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: split InitializeThreadLocal into two parts Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright 2006-2008 the V8 project authors. All rights reserved. 2 // Copyright 2006-2008 the V8 project authors. All rights reserved.
3 // Redistribution and use in source and binary forms, with or without 3 // Redistribution and use in source and binary forms, with or without
4 // modification, are permitted provided that the following conditions are 4 // modification, are permitted provided that the following conditions are
5 // met: 5 // met:
6 // 6 //
7 // * Redistributions of source code must retain the above copyright 7 // * Redistributions of source code must retain the above copyright
8 // notice, this list of conditions and the following disclaimer. 8 // notice, this list of conditions and the following disclaimer.
9 // * Redistributions in binary form must reproduce the above 9 // * Redistributions in binary form must reproduce the above
10 // copyright notice, this list of conditions and the following 10 // copyright notice, this list of conditions and the following
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 int start = 0; 74 int start = 0;
75 int end = 0; 75 int end = 0;
76 Handle<Object> script_handle = FACTORY->undefined_value(); 76 Handle<Object> script_handle = FACTORY->undefined_value();
77 if (loc) { 77 if (loc) {
78 start = loc->start_pos(); 78 start = loc->start_pos();
79 end = loc->end_pos(); 79 end = loc->end_pos();
80 script_handle = GetScriptWrapper(loc->script()); 80 script_handle = GetScriptWrapper(loc->script());
81 } 81 }
82 82
83 Handle<Object> stack_trace_handle = stack_trace.is_null() 83 Handle<Object> stack_trace_handle = stack_trace.is_null()
84 ? FACTORY->undefined_value() 84 ? Handle<Object>::cast(FACTORY->undefined_value())
85 : Handle<Object>::cast(stack_trace); 85 : Handle<Object>::cast(stack_trace);
86 86
87 Handle<Object> stack_frames_handle = stack_frames.is_null() 87 Handle<Object> stack_frames_handle = stack_frames.is_null()
88 ? FACTORY->undefined_value() 88 ? Handle<Object>::cast(FACTORY->undefined_value())
89 : Handle<Object>::cast(stack_frames); 89 : Handle<Object>::cast(stack_frames);
90 90
91 Handle<JSMessageObject> message = 91 Handle<JSMessageObject> message =
92 FACTORY->NewJSMessageObject(type_handle, 92 FACTORY->NewJSMessageObject(type_handle,
93 arguments_handle, 93 arguments_handle,
94 start, 94 start,
95 end, 95 end,
96 script_handle, 96 script_handle,
97 stack_trace_handle, 97 stack_trace_handle,
98 stack_frames_handle); 98 stack_frames_handle);
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 171
172 172
173 SmartArrayPointer<char> MessageHandler::GetLocalizedMessage( 173 SmartArrayPointer<char> MessageHandler::GetLocalizedMessage(
174 Handle<Object> data) { 174 Handle<Object> data) {
175 HandleScope scope; 175 HandleScope scope;
176 return GetMessage(data)->ToCString(DISALLOW_NULLS); 176 return GetMessage(data)->ToCString(DISALLOW_NULLS);
177 } 177 }
178 178
179 179
180 } } // namespace v8::internal 180 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698