Make sure it's possible to download to a network share....

Make sure it's possible to download to a network share.

The function to move the file was failing to set the
security descriptor. Now we use SHFileOperation, which
has a flag to do everything we want.

Eventually we might want to display ui on errors and
use the ui features of SHFileOperation, but for the
1.0 build we want to stick to a smaller and less risky
change.

BUG: 984

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3996

[amit, 2008-10-24 17:45:34]

LGTM

http://codereview.chromium.org/8128/diff/1/2
File base/file_util_win.cc (right):

http://codereview.chromium.org/8128/diff/1/2#newcode553
Line 553: return false;
Would be nice to log an error if this fails.

[rvargas (doing something else), 2008-10-24 18:00:22]

LGTM with one nit.

http://codereview.chromium.org/8128/diff/1/2
File base/file_util_win.cc (right):

http://codereview.chromium.org/8128/diff/1/2#newcode550
Line 550: FOF_NOCONFIRMMKDIR | FOF_NOCOPYSECURITYATTRIBS;
nit: don't we want to use FOF_RENAMEONCOLLISION?

[Paul Godavari, 2008-10-25 00:42:15]

LGTM.

http://codereview.chromium.org/8128/diff/1/3
File base/file_util.h (right):

http://codereview.chromium.org/8128/diff/1/3#newcode349
Line 349: // Renames a file using the SHFileOperation API to ensures that the
target file
'ensure'