Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 8124025: Fix issue 1361 - Implement ES5 Array.prototype.toString. (Closed)

Created:
9 years, 2 months ago by Lasse Reichstein
Modified:
9 years, 2 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 1361 - Implement ES5 Array.prototype.toString. BUG=v8:1361 TEST=mjsunit/array-tostring Committed: http://code.google.com/p/v8/source/detail?r=9519

Patch Set 1 #

Total comments: 6

Patch Set 2 : Added toLocaleString #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -21 lines) Patch
M src/array.js View 1 2 chunks +25 lines, -15 lines 0 comments Download
A test/mjsunit/array-tostring.js View 1 1 chunk +159 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-877615.js View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein
9 years, 2 months ago (2011-10-04 11:53:11 UTC) #1
Rico
http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js File test/mjsunit/array-tostring.js (right): http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js#newcode78 test/mjsunit/array-tostring.js:78: Add comment on what we are testing, e.g., // ...
9 years, 2 months ago (2011-10-04 12:10:45 UTC) #2
Rico
And LGTM
9 years, 2 months ago (2011-10-04 12:10:57 UTC) #3
Lasse Reichstein
http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js File test/mjsunit/array-tostring.js (right): http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js#newcode104 test/mjsunit/array-tostring.js:104: assertFalse(called_before); Pretty much, yes. I blame Emacs. http://codereview.chromium.org/8124025/diff/1/test/mjsunit/array-tostring.js#newcode110 test/mjsunit/array-tostring.js:110: ...
9 years, 2 months ago (2011-10-04 12:56:33 UTC) #4
Rico
9 years, 2 months ago (2011-10-04 13:01:49 UTC) #5
Still lgtm

Powered by Google App Engine
This is Rietveld 408576698