Applescript: return value from execute javascript command

content/browser/renderer_host/render_view_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "base/process_util.h"
 #include "content/browser/renderer_host/render_widget_host.h"
 #include "content/common/content_export.h"
 #include "content/common/window_container_type.h"
 #include "net/base/load_states.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebConsoleMessage.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDragOperation.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPopupType.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebTextDirection.h"
 #include "webkit/glue/webaccessibility.h"
 #include "webkit/glue/window_open_disposition.h"
 
+#include "base/values.h"
+#include "content/common/notification_observer.h"
+
 class ChildProcessSecurityPolicy;
 struct DesktopNotificationHostMsg_Show_Params;
 class FilePath;
 class GURL;
 class RenderViewHostDelegate;
 class RenderViewHostObserver;
 class SessionStorageNamespace;
 class SiteInstance;
 class SkBitmap;
 class ViewMsg_Navigate;
@@ skipping 27 matching lines @@
 
 namespace WebKit {
 struct WebMediaPlayerAction;
 struct WebFindOptions;
 }  // namespace WebKit
 
 namespace net {
 class URLRequestContextGetter;
 }
 
+// NotificationObserver used to listen for EXECUTE_JAVASCRIPT_RESULT
+// notifications.
+class ExecuteNotificationObserver : public NotificationObserver {
+ public:
+  ExecuteNotificationObserver(int id);

[Avi (use Gerrit), 2011/10/17 14:20:38]

one param constructors should be "explicit"

[keishi, 2011/10/21 05:05:43]

Done.

+  virtual ~ExecuteNotificationObserver();
+  virtual void Observe(int type,
+                       const NotificationSource& source,
+                       const NotificationDetails& details);
+
+  int id() const { return id_; }
+
+  Value* value() const { return value_.get(); }
+
+ private:
+  int id_;
+  scoped_ptr<Value> value_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExecuteNotificationObserver);
+};
+
 //
 // RenderViewHost
 //
 //  A RenderViewHost is responsible for creating and talking to a RenderView
 //  object in a child process. It exposes a high level API to users, for things
 //  like loading pages, adjusting the display and other browser functionality,
 //  which it translates into IPC messages sent over the IPC channel with the
 //  RenderView. It responds to all IPC messages sent by that RenderView and
 //  cracks them, calling a delegate object back with higher level types where
 //  possible.
@@ skipping 166 matching lines @@
 
   // Runs some javascript within the context of a frame in the page.
   void ExecuteJavascriptInWebFrame(const string16& frame_xpath,
                                    const string16& jscript);
 
   // Runs some javascript within the context of a frame in the page. The result
   // is sent back via the notification EXECUTE_JAVASCRIPT_RESULT.
   int ExecuteJavascriptInWebFrameNotifyResult(const string16& frame_xpath,
                                               const string16& jscript);
 
+  Value* ExecuteJavascriptAndGetValue(const string16& frame_xpath,
+                                    const string16& jscript);

[Avi (use Gerrit), 2011/10/17 14:20:38]

align params, add comment; do we want to merge this with ExecuteJSInWebFrame?

[keishi, 2011/10/21 05:05:43]

Do you want me to add an argument to ExecuteJavascriptInWebFrame? Like
void ExecuteJavascriptInWebFrame(const string16& frame_xpath,
                                    const string16& jscript,
                                    bool return_value);

[Avi (use Gerrit), 2011/10/21 11:50:48]

hmmmm... What fraction of the users bother to set up an environment to capture
the result and would use it? If low, then it's probably not worth bothering. In
any case, leave it for another changelist.

+
+
   // Notifies the RenderView that the JavaScript message that was shown was
   // closed by the user.
   void JavaScriptDialogClosed(IPC::Message* reply_msg,
                               bool success,
                               const string16& user_input);
 
   // Notifies the renderer that a a drag operation that it started has ended,
   // either in a drop or by being cancelled.
   void DragSourceEndedAt(
       int client_x, int client_y, int screen_x, int screen_y,
@@ skipping 361 matching lines @@
   // The termination status of the last render view that terminated.
   base::TerminationStatus render_view_termination_status_;
 
   // A list of observers that filter messages.  Weak references.
   ObserverList<RenderViewHostObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewHost);
 };
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_