Applescript: return value from execute javascript command

content/browser/renderer_host/render_view_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 32 matching lines @@
 #include "content/public/common/bindings_policy.h"
 #include "content/public/common/url_constants.h"
 #include "net/base/net_util.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/native_widget_types.h"
 #include "webkit/glue/context_menu.h"
 #include "webkit/glue/webaccessibility.h"
 #include "webkit/glue/webdropdata.h"
 
+#include "content/common/notification_details.h"
+
 using base::TimeDelta;
 using WebKit::WebConsoleMessage;
 using WebKit::WebDragOperation;
 using WebKit::WebDragOperationNone;
 using WebKit::WebDragOperationsMask;
 using WebKit::WebInputEvent;
 using WebKit::WebMediaPlayerAction;
 
 namespace {
 
@@ skipping 411 matching lines @@
 
 int RenderViewHost::ExecuteJavascriptInWebFrameNotifyResult(
     const string16& frame_xpath,
     const string16& jscript) {
   static int next_id = 1;
   Send(new ViewMsg_ScriptEvalRequest(routing_id(), frame_xpath, jscript,
                                      next_id, true));
   return next_id++;
 }
 
+typedef std::pair<int, Value*> ExecuteDetailType;
+
+ExecuteNotificationObserver::ExecuteNotificationObserver(int id) : id_(id) { }

[Avi (use Gerrit), 2011/10/17 14:20:38]

adhere to style guide

[keishi, 2011/10/21 05:05:43]

Done.

+ExecuteNotificationObserver::~ExecuteNotificationObserver() { }

[Avi (use Gerrit), 2011/10/17 14:20:38]

ditto

[keishi, 2011/10/21 05:05:43]

Done.

+void ExecuteNotificationObserver::Observe(int type,
+                     const NotificationSource& source,
+                     const NotificationDetails& details)
+{

[Avi (use Gerrit), 2011/10/17 14:20:38]

opening brace always on previous line

[keishi, 2011/10/21 05:05:43]

Done.

+  int id = (static_cast<Details<ExecuteDetailType > >(details))->first;

[Avi (use Gerrit), 2011/10/17 14:20:38]

no space before first >

[keishi, 2011/10/21 05:05:43]

Done.

+  if (id != id_)
+    return;
+  Value* value = (static_cast<Details<ExecuteDetailType > >(details))->second;

[Avi (use Gerrit), 2011/10/17 14:20:38]

ditto

[keishi, 2011/10/21 05:05:43]

Done.

+  if (value)
+    value_.reset(value->DeepCopy());
+  MessageLoop::current()->Quit();
+}
+
+Value* RenderViewHost::ExecuteJavascriptAndGetValue(const string16& frame_xpath,
+                                  const string16& jscript) {

[Avi (use Gerrit), 2011/10/17 14:20:38]

align params

[keishi, 2011/10/21 05:05:43]

Done.

+  int id = ExecuteJavascriptInWebFrameNotifyResult(frame_xpath, jscript);
+  ExecuteNotificationObserver observer(id);
+  NotificationRegistrar notification_registrar;
+  notification_registrar.Add(
+      &observer, content::NOTIFICATION_EXECUTE_JAVASCRIPT_RESULT,
+      Source<RenderViewHost>(this));
+  MessageLoop* loop = MessageLoop::current();
+  loop->Run();
+  return observer.value()->DeepCopy();

[Avi (use Gerrit), 2011/10/17 14:20:38]

We make two copies?

[keishi, 2011/10/21 05:05:43]

The value must outlive the observer so this copy is necessary.

+}
+
 void RenderViewHost::JavaScriptDialogClosed(IPC::Message* reply_msg,
                                             bool success,
                                             const string16& user_input) {
   process()->set_ignore_input_events(false);
   bool is_waiting =
       is_waiting_for_beforeunload_ack_ || is_waiting_for_unload_ack_;
   if (is_waiting)
     StartHangMonitorTimeout(TimeDelta::FromMilliseconds(kUnloadTimeoutMS));
 
   ViewHostMsg_RunJavaScriptMessage::WriteReplyParams(reply_msg,
@@ skipping 933 matching lines @@
 void RenderViewHost::OnRunFileChooser(
     const ViewHostMsg_RunFileChooser_Params& params) {
   delegate_->RunFileChooser(this, params);
 }
 
 void RenderViewHost::OnWebUISend(const GURL& source_url,
                                  const std::string& name,
                                  const base::ListValue& args) {
   delegate_->WebUISend(this, source_url, name, args);
 }