Issue 8124010: Replace <meta> tag with header for content-security-policy on chrome:// pages.

Issue 8124010: Replace <meta> tag with header for content-security-policy on chrome:// pages. (Closed)

Created:
9 years, 2 months ago by Tom Sepez

Modified:
9 years, 2 months ago

Reviewers:
Evan Stade, abarth-chromium

CC:
chromium-reviews, asanka, Nirnimesh, John Grabowski, eroman, yoshiki+watch_chromium.org, Randy Smith (Not in Mondays), anantha, arv (Not doing code reviews), dyu1, Paweł Hajdan Jr., dennis_jeffrey, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Replace <meta> tag with header for content-security-policy on chrome:// pages. By default, all chrome:// pages will get CSP with a whitelist of the exceptions. BUG=98877 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104134

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -59 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/about_conflicts.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/about_flash.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/about_memory.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/about_memory_linux.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/about_memory_mac.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/about_stats.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/about_version.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/bug_report.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/bug_report_invalid.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/browser/resources/content_security_policy.html	View	1 2 3	1 chunk	+0 lines, -18 lines	0 comments	Download
M	chrome/browser/resources/crashes.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/downloads.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/flags.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/gpu_internals.html	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/history.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/history2.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/hung_renderer_dialog.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/media_internals.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/net_internals/help.html	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/net_internals/index.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/options.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/plugins.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/policy.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/quota_internals/main.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/sessions.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/sync_internals/sync_index.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/task_manager/main.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/tracing.html	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/workers/index.html	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chrome_url_data_manager_backend.cc	View	1 2 3	3 chunks	+58 lines, -0 lines	0 comments	Download
M	chrome/test/functional/special_tabs.py	View	1 2 3	4 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

This looks fine except for the bookmark manager change. I'd skip that one for now ...

9 years, 2 months ago (2011-10-03 23:10:54 UTC) #2

Tom Sepez

Would like to have a test showing CSP still works in the special_tabs.py tests, but ...

9 years, 2 months ago (2011-10-03 23:15:46 UTC) #3

Evan Stade

9 years, 2 months ago (2011-10-04 02:28:55 UTC) #4

lgtm

http://codereview.chromium.org/8124010/diff/38/chrome/browser/ui/webui/chrome...
File chrome/browser/ui/webui/chrome_url_data_manager_backend.cc (right):

http://codereview.chromium.org/8124010/diff/38/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chrome_url_data_manager_backend.cc:89:
g_ChromeURLContentSecurityPolicyExceptions(base::LINKER_INITIALIZED);
wrong var name style (should be c style)

Expand Messages | Collapse Messages