Component updater: send extra attributes in the request to

Component updater: send extra attributes in the request to
facilitate the crx configuration explosion.

Now the client send os=foo&arch=bar along with the usual request. for example os=win&arch=x86

TEST=see bug
BUG=61602
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104044

[asargent_no_longer_on_chrome, 2011-10-04 23:29:42]

LGTM

http://codereview.chromium.org/8122015/diff/1/chrome/browser/component_update...
File chrome/browser/component_updater/component_updater_configurator.cc (right):

http://codereview.chromium.org/8122015/diff/1/chrome/browser/component_update...
chrome/browser/component_updater/component_updater_configurator.cc:68:
"os=other&arch=other";
Instead of using "other" here in the cases of new OS / architectures that this
code doesn't know about, would it be better to instead have:

#error "unknown os or architecture"

so that we'll get a compile error, and someone will have to think about what the
right thing is to put here?

[cpu_(ooo_6.6-7.5), 2011-10-05 00:19:17]

Sounds good. I'll do that. 

On 2011/10/04 23:29:42, Antony Sargent wrote:
> LGTM
> 
>
http://codereview.chromium.org/8122015/diff/1/chrome/browser/component_update...
> File chrome/browser/component_updater/component_updater_configurator.cc
(right):
> 
>
http://codereview.chromium.org/8122015/diff/1/chrome/browser/component_update...
> chrome/browser/component_updater/component_updater_configurator.cc:68:
> "os=other&arch=other";
> Instead of using "other" here in the cases of new OS / architectures that this
> code doesn't know about, would it be better to instead have:
> 
> #error "unknown os or architecture"
> 
> so that we'll get a compile error, and someone will have to think about what
the
> right thing is to put here?

[Nikita (slow), 2011-10-05 08:08:05]

This change broke ARM buildbots.
http://build.chromium.org/p/chromium.chromiumos/console

[asargent_no_longer_on_chrome, 2011-10-05 22:59:48]

Success! We've already found the first platform that you weren't handling.
It might have been months before we looked at the backend data and realized
this. =)


On Wed, Oct 5, 2011 at 1:08 AM, <nkostylev@chromium.org> wrote:

> This change broke ARM buildbots.
>
http://build.chromium.org/p/**chromium.chromiumos/console<http://build.chromi...
>
>
http://codereview.chromium.**org/8122015/<http://codereview.chromium.org/8122...
>