Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 8122006: Fix lack of preview when GCP printer is selected. (Closed)

Created:
9 years, 2 months ago by Albert Bodenhamer
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix lack of preview when GCP printer is selected. Add handling for the cloud print dialog to update settings code on Mac and Windows. BUG=98929 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103937

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M printing/printing_context_mac.mm View 1 2 chunks +4 lines, -2 lines 0 comments Download
M printing/printing_context_win.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Albert Bodenhamer
9 years, 2 months ago (2011-10-03 22:12:53 UTC) #1
kmadhusu
http://codereview.chromium.org/8122006/diff/1/printing/printing_context_mac.mm File printing/printing_context_mac.mm (right): http://codereview.chromium.org/8122006/diff/1/printing/printing_context_mac.mm#newcode130 printing/printing_context_mac.mm:130: job_settings.GetBoolean(printing::kSettingCloudPrintDialog, &is_cloud_dialog); Please add this line to the previous ...
9 years, 2 months ago (2011-10-03 22:15:10 UTC) #2
Albert Bodenhamer
http://codereview.chromium.org/8122006/diff/1/printing/printing_context_mac.mm File printing/printing_context_mac.mm (right): http://codereview.chromium.org/8122006/diff/1/printing/printing_context_mac.mm#newcode130 printing/printing_context_mac.mm:130: job_settings.GetBoolean(printing::kSettingCloudPrintDialog, &is_cloud_dialog); On 2011/10/03 22:15:10, kmadhusu wrote: > Please ...
9 years, 2 months ago (2011-10-03 22:38:39 UTC) #3
kmadhusu
lgtm
9 years, 2 months ago (2011-10-03 22:43:03 UTC) #4
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8122006/3002
9 years, 2 months ago (2011-10-04 16:46:15 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-04 18:06:31 UTC) #6
Change committed as 103937

Powered by Google App Engine
This is Rietveld 408576698