Move more immutable members to DependencySettings.

Move more immutable members to DependencySettings.

Helps figuring out what is mutable and what is not.
The goal is to shorten the class Dependency to reduce places where mutations can occur.

R=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103782

[Dirk Pranke, 2011-10-03 21:10:04]

lgtm with comments.

http://codereview.chromium.org/8122005/diff/1/gclient.py
File gclient.py (right):

http://codereview.chromium.org/8122005/diff/1/gclient.py#newcode225
gclient.py:225: Immutable so no need to lock.
Nit: if you're deleting the "immutable" comments from the other lines (which
makes sense), might as well delete it here, too.

http://codereview.chromium.org/8122005/diff/1/gclient.py#newcode229
gclient.py:229: def get_custom_deps(self, name, url):
Should this be a property (i.e., @property def custom_deps) as well?

[M-A Ruel, 2011-10-03 21:29:48]

http://codereview.chromium.org/8122005/diff/1/gclient.py
File gclient.py (right):

http://codereview.chromium.org/8122005/diff/1/gclient.py#newcode225
gclient.py:225: Immutable so no need to lock.
On 2011/10/03 21:10:04, Dirk Pranke wrote:
> Nit: if you're deleting the "immutable" comments from the other lines (which
> makes sense), might as well delete it here, too.

Thanks, copy-paste fail.

http://codereview.chromium.org/8122005/diff/1/gclient.py#newcode229
gclient.py:229: def get_custom_deps(self, name, url):
On 2011/10/03 21:10:04, Dirk Pranke wrote:
> Should this be a property (i.e., @property def custom_deps) as well?

there's already a custom_deps property. This one is a function since it needs 2
args and it'd be wasteful to consrtuct a temporary dict with all the parent just
to do a lookup.

[commit-bot: I haz the power, 2011-10-03 21:30:00]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8122005/3002

[commit-bot: I haz the power, 2011-10-03 21:36:03]

Change committed as 103782