Issue 8121001: Add a unit test to breakpad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8121001: Add a unit test to breakpad. (Closed)

Created:
9 years, 2 months ago by M-A Ruel

Modified:
9 years, 2 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add a unit test to breakpad. While re-reading the code, I thought I had found a bug but I hadn't. So I wrote the test to document the behavior to not make the same error again. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103772

Patch Set 1 #

Total comments: 1

Patch Set 2 : change function name #

Patch Set 3 : Fix for python 2.6 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -2 lines)			Patch
	M	breakpad.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	A	tests/breakpad_unittest.py	View	1 2	1 chunk	+118 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

lgtm otherwise. http://codereview.chromium.org/8121001/diff/1/tests/breakpad_unittest.py File tests/breakpad_unittest.py (right): http://codereview.chromium.org/8121001/diff/1/tests/breakpad_unittest.py#newcode44 tests/breakpad_unittest.py:44: def _part1(self, exception): Nit: can you come ...

9 years, 2 months ago (2011-10-03 19:09:16 UTC) #2

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8121001/4001

9 years, 2 months ago (2011-10-03 19:15:18 UTC) #3

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8121001/4003

9 years, 2 months ago (2011-10-03 20:40:10 UTC) #4

Change committed as 103772

Expand Messages | Collapse Messages