Add ScopedClosureRunner.

Add ScopedClosureRunner.

BUG=None
TEST=Unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103900

[awong, 2011-10-04 00:22:42]

2 nits.

http://codereview.chromium.org/8120015/diff/1/base/task.cc
File base/task.cc (right):

http://codereview.chromium.org/8120015/diff/1/base/task.cc#newcode48
base/task.cc:48: closure_ = Closure();
closure_.Reset();

http://codereview.chromium.org/8120015/diff/1/base/task.h
File base/task.h (right):

http://codereview.chromium.org/8120015/diff/1/base/task.h#newcode572
base/task.h:572: // Takes ownership of the task.
Comment is stale.

[Sergey Ulanov, 2011-10-04 00:25:10]

http://codereview.chromium.org/8120015/diff/1/base/task.cc
File base/task.cc (right):

http://codereview.chromium.org/8120015/diff/1/base/task.cc#newcode48
base/task.cc:48: closure_ = Closure();
On 2011/10/04 00:22:42, awong wrote:
> closure_.Reset();

Done.

http://codereview.chromium.org/8120015/diff/1/base/task.h
File base/task.h (right):

http://codereview.chromium.org/8120015/diff/1/base/task.h#newcode572
base/task.h:572: // Takes ownership of the task.
On 2011/10/04 00:22:42, awong wrote:
> Comment is stale.

Done.

[awong, 2011-10-04 00:27:36]

LGTM

Will, there's been a few requests for this already so I think it makes sense to
dunk in as an analogue to ScopedTaskRunner.

[awong, 2011-10-04 00:28:00]

Oh, and Sergey, please fix up the BUG=, TEST=.

On 2011/10/04 00:27:36, awong wrote:
> LGTM
> 
> Will, there's been a few requests for this already so I think it makes sense
to
> dunk in as an analogue to ScopedTaskRunner.

[willchan no longer on Chromium, 2011-10-04 00:45:01]

LGTM once you address ajwong's points.

On Mon, Oct 3, 2011 at 5:28 PM, <ajwong@chromium.org> wrote:

> Oh, and Sergey, please fix up the BUG=, TEST=.
>
>
> On 2011/10/04 00:27:36, awong wrote:
>
>> LGTM
>>
>
>  Will, there's been a few requests for this already so I think it makes
>> sense
>>
> to
>
>> dunk in as an analogue to ScopedTaskRunner.
>>
>
>
>
>
http://codereview.chromium.**org/8120015/<http://codereview.chromium.org/8120...
>

[Sergey Ulanov, 2011-10-04 00:54:05]

On 2011/10/04 00:28:00, awong wrote:
> Oh, and Sergey, please fix up the BUG=, TEST=.
Done. And also added unittests?


> 
> On 2011/10/04 00:27:36, awong wrote:
> > LGTM
> > 
> > Will, there's been a few requests for this already so I think it makes sense
> to
> > dunk in as an analogue to ScopedTaskRunner.

[willchan no longer on Chromium, 2011-10-04 00:55:08]

I defer the rest of this review to Albert.

On Mon, Oct 3, 2011 at 5:54 PM, <sergeyu@chromium.org> wrote:

> On 2011/10/04 00:28:00, awong wrote:
>
>> Oh, and Sergey, please fix up the BUG=, TEST=.
>>
> Done. And also added unittests?
>
>
>
>
>  On 2011/10/04 00:27:36, awong wrote:
>> > LGTM
>> >
>> > Will, there's been a few requests for this already so I think it makes
>> sense
>> to
>> > dunk in as an analogue to ScopedTaskRunner.
>>
>
>
>
>
http://codereview.chromium.**org/8120015/<http://codereview.chromium.org/8120...
>

[commit-bot: I haz the power, 2011-10-04 13:40:48]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8120015/4002

[commit-bot: I haz the power, 2011-10-04 15:28:05]

Change committed as 103900