patches/gcc46.patch - Issue 8120001: Make it compile with -Werror on gcc 4.6

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: patches/gcc46.patch

Issue 8120001: Make it compile with -Werror on gcc 4.6 (Closed) Base URL: http://git.chromium.org/chromium/deps/icu46.git@master

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/public/common/unicode/unistr.h b/public/common/unicode/unistr.h

	2 index 57ea346..9aba6f0 100644

	3 --- a/public/common/unicode/unistr.h

	4 +++ b/public/common/unicode/unistr.h

	5 @@ -4023,6 +4023,7 @@ UnicodeString::replace(int32_t start,

	6 int32_t count = 0;

	7 UBool isError = FALSE;

	8 U16_APPEND(buffer, count, U16_MAX_LENGTH, srcChar, isError);

	9 + (void) isError;

	10 return doReplace(start, _length, buffer, 0, count);

	11 }

	12

	13 @@ -4326,6 +4327,7 @@ UnicodeString::append(UChar32 srcChar) {

	14 int32_t _length = 0;

	15 UBool isError = FALSE;

	16 U16_APPEND(buffer, _length, U16_MAX_LENGTH, srcChar, isError);

	17 + (void) isError;

	18 return doReplace(length(), 0, buffer, 0, _length);

	19 }

	20

OLD	NEW

« no previous file with comments | « README.chromium ('k') | public/common/unicode/unistr.h » ('j') | no next file with comments »